Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

["Vesa Jääskeläinen" <chaac@nic.fi>]

Robert Millan wrote:
> On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
>> +int
>> +grub_err_printf (const char *fmt, ...)
>> +{
>> +  va_list ap;
>> +  int ret;
>> +  
>> +  va_start (ap, fmt);
>> +  ret = vfprintf (stderr, fmt, ap);
>> +  va_end (ap);
>> +
>> +  return ret;
>> +}
>>  void *
>>  xmalloc (size_t size)
> 
> Please separate functions with an empty line.  Anyway, no need to send a new
> patch just for this.
> 
> Marco, is it fine to you now?
> 

Please use grub's own string formatter.