From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
Date: Thu, 14 Aug 2008 20:08:06 +0200 [thread overview]
Message-ID: <20080814180806.GA18309@thorin> (raw)
In-Reply-To: <1218711750.5154.11.camel@fz.local>
On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
> +int
> +grub_err_printf (const char *fmt, ...)
> +{
> + va_list ap;
> + int ret;
> +
> + va_start (ap, fmt);
> + ret = vfprintf (stderr, fmt, ap);
> + va_end (ap);
> +
> + return ret;
> +}
> void *
> xmalloc (size_t size)
Please separate functions with an empty line. Anyway, no need to send a new
patch just for this.
Marco, is it fine to you now?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-14 18:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 16:28 [PATCH] kern/err.c + disk/raid.c error handling fixes Felix Zielcke
2008-08-12 16:32 ` Felix Zielcke
2008-08-12 21:42 ` Marco Gerards
2008-08-12 22:40 ` Robert Millan
2008-08-13 5:56 ` Felix Zielcke
2008-08-13 9:47 ` Marco Gerards
2008-08-13 20:31 ` Felix Zielcke
2008-08-13 20:38 ` Felix Zielcke
2008-08-13 21:50 ` Robert Millan
2008-08-13 22:39 ` Felix Zielcke
2008-08-13 23:30 ` Felix Zielcke
2008-08-14 7:13 ` Marco Gerards
2008-08-14 11:02 ` Felix Zielcke
2008-08-14 18:08 ` Robert Millan [this message]
2008-08-14 18:16 ` Vesa Jääskeläinen
2008-08-14 18:27 ` Marco Gerards
2008-08-14 18:48 ` Felix Zielcke
2008-08-13 23:32 ` Robert Millan
2008-08-13 9:40 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814180806.GA18309@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.