Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

[Marco Gerards <mgerards@xs4all.nl>]

Robert Millan <rmh@aybabtu.com> writes:

> On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
>> >           [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead of   
>> >           grub_printf.
>> 
>> Why?
>> 
>> It would be better to make a util/misc.c:grub_print_error instead of this
>
> Problem is that kern/err.c is already included in grub-probe.  So then we would
> have to add util/misc.c:grub_print_error _and_ disable grub_print_error.

That might be better than adding fprintf to kern/ IMO.

>> Please use -up for diff, you can use:
>> $ svn diff --diff-cmd diff -x -up
>
> Thanks for the tip, I've been looking for this ;-)

Now if only everyone would use this... :-)

--
Marco