Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

[Marco Gerards <mgerards@xs4all.nl>]

Felix Zielcke <fzielcke@z-51.de> writes:

> Am Dienstag, den 12.08.2008, 18:28 +0200 schrieb Felix Zielcke:
>
> Ok naming the old patch kern_err.diff and the new one raid_err.diff
> isn't a good idea :(
>
>
> 2008-08-12  Felix Zielcke <fzielcke@z-51.de>
>   
>         * kern/err.c [GRUB_UTIL]: Include <stdio.h>.

Please don't do this.  Why do you want this?

>           [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead of   
>           grub_printf.

Why?

It would be better to make a util/misc.c:grub_print_error instead of this

>         * disk/raid.c (GRUB_MOD_INIT): Use grub_print_error() to show RAID 
>         errors and reset grub_errno. Do not give errors to the upper layer.

"...reset grub_errno.  Do not..."
(double space)

> Index: disk/raid.c
> ===================================================================
> --- disk/raid.c	(revision 1800)
> +++ disk/raid.c	(working copy)
> @@ -581,6 +581,8 @@
>  {

Please use -up for diff, you can use:
$ svn diff --diff-cmd diff -x -up

>    grub_device_iterate (&grub_raid_scan_device);
>    grub_disk_dev_register (&grub_raid_dev);
> +  grub_print_error ();
> +  grub_errno = GRUB_ERR_NONE;
>  }
>  
>  GRUB_MOD_FINI(raid)