All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Post <echo@echoreply.us>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] 1/1 Better expose xenstore limits
Date: Thu, 30 Apr 2009 18:02:54 +0800	[thread overview]
Message-ID: <1241085774.5394.211.camel@localhost.localdomain> (raw)
In-Reply-To: <C61F2F65.9D53%keir.fraser@eu.citrix.com>

On Thu, 2009-04-30 at 10:35 +0100, Keir Fraser wrote:
> On 30/04/2009 09:54, "Tim Post" <echo@echoreply.us> wrote:
> 
> >> Defining the same thing again but with a different name just for purposes of
> >> documentation is pretty barking. I suppose it is perhaps worth a
> >> documentation comment in xs.h, but no more than that.
> > 
> > It is worth a mention... though it seems silly to send a patch that adds
> > comments. However, a patch that would convert the comments in xs to
> > doxygen format seems more useful, with the appropriate grouping, shorts,
> > etc.
> > 
> > How receptive would you be to that?
> 
> I don't have a strong opinion. You can go wild on that if you like, assuming
> noone else hates doxygen format for any reason. I added a limits-related
> comment to xs.h by the way.

Well, since we have doxygen in the build, and the generated html docs
are so easy to read .. seems sort of silly not to make it uniform :)

If nobody replies with a resounding PLEASE NO, I'll go ahead and do
it .. libxc needs some comment love anyway.

It is very frustrating and difficult for people to write apps that work
with Xen using the shipped (or wiki) documentation. All too often,
what's on the wiki is not in step with unstable, so each new release is
like an easter egg hunt.

I also have some autoconf macros that I'll post to help stop breakage
due to structures shifting members. from the earlier days of v3 (but
still in use).

Cheers,
--Tim

      reply	other threads:[~2009-04-30 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 16:43 [PATCH] 1/1 Better expose xenstore limits Tim Post
2009-04-29 18:01 ` Keir Fraser
2009-04-29 18:18   ` Tim Post
2009-04-29 21:23     ` Keir Fraser
2009-04-30  8:54       ` Tim Post
2009-04-30  9:35         ` Keir Fraser
2009-04-30 10:02           ` Tim Post [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241085774.5394.211.camel@localhost.localdomain \
    --to=echo@echoreply.us \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.