All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] 1/1 Better expose xenstore limits
Date: Wed, 29 Apr 2009 19:01:38 +0100	[thread overview]
Message-ID: <C61E5492.9BE4%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <1241023383.5394.162.camel@localhost.localdomain>

On 29/04/2009 17:43, "Tim Post" <echo@echoreply.us> wrote:

> Since xs.h already includes xs_wire, this patch duplicates those limits
> as XS_PAYLOAD_MAX, XS_ABS_PATH_MAX and XS_REL_PATH_MAX. Moving these
> would be a pain, but they really need to be advertised.
> 
> Such limits should be obvious in the headers that people actually use
> outside of the kernel, saving them from wondering what went wrong.
> 
> Added comments direct people to xs_wire.h , in case those limits change.

In terms of documentation, docs/misc/xenstore.txt already does a fine job.
And I think a xen/public/... header is the right place for the limits, since
it is a general documented protocol-level constraint, rather than a
constraint of the particular client library (which is the scope of xs.h
itself).

 -- Keir

  reply	other threads:[~2009-04-29 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 16:43 [PATCH] 1/1 Better expose xenstore limits Tim Post
2009-04-29 18:01 ` Keir Fraser [this message]
2009-04-29 18:18   ` Tim Post
2009-04-29 21:23     ` Keir Fraser
2009-04-30  8:54       ` Tim Post
2009-04-30  9:35         ` Keir Fraser
2009-04-30 10:02           ` Tim Post

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C61E5492.9BE4%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.