All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] 1/1 Better expose xenstore limits
Date: Thu, 30 Apr 2009 10:35:17 +0100	[thread overview]
Message-ID: <C61F2F65.9D53%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <1241081691.5394.192.camel@localhost.localdomain>

On 30/04/2009 09:54, "Tim Post" <echo@echoreply.us> wrote:

>> Defining the same thing again but with a different name just for purposes of
>> documentation is pretty barking. I suppose it is perhaps worth a
>> documentation comment in xs.h, but no more than that.
> 
> It is worth a mention... though it seems silly to send a patch that adds
> comments. However, a patch that would convert the comments in xs to
> doxygen format seems more useful, with the appropriate grouping, shorts,
> etc.
> 
> How receptive would you be to that?

I don't have a strong opinion. You can go wild on that if you like, assuming
noone else hates doxygen format for any reason. I added a limits-related
comment to xs.h by the way.

 -- Keir

  reply	other threads:[~2009-04-30  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 16:43 [PATCH] 1/1 Better expose xenstore limits Tim Post
2009-04-29 18:01 ` Keir Fraser
2009-04-29 18:18   ` Tim Post
2009-04-29 21:23     ` Keir Fraser
2009-04-30  8:54       ` Tim Post
2009-04-30  9:35         ` Keir Fraser [this message]
2009-04-30 10:02           ` Tim Post

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C61F2F65.9D53%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.