Re: [PATCH] 1/1 Better expose xenstore limits

[Tim Post <echo@echoreply.us>]

On Wed, 2009-04-29 at 22:23 +0100, Keir Fraser wrote:
> On 29/04/2009 19:18, "Tim Post" <echo@echoreply.us> wrote:
> 
> > Someone using xs.h is going to be entirely unaware of said limits.
> > Xenstore internals will relay an appropriate errno if the limits are
> > exceeded, but I think many people will not know such limits exist.
> > 
> > Xenwire is used when developing drivers.. not user space applications.
> > 
> > Why not assert the limits in both at the cost of bothering the
> > preprocessor three times?
> 
> Defining the same thing again but with a different name just for purposes of
> documentation is pretty barking. I suppose it is perhaps worth a
> documentation comment in xs.h, but no more than that.

It is worth a mention... though it seems silly to send a patch that adds
comments. However, a patch that would convert the comments in xs to
doxygen format seems more useful, with the appropriate grouping, shorts,
etc.

How receptive would you be to that?

Cheers,
--Tim