From: Tim Post <echo@echoreply.us>
To: xen-devel@lists.xensource.com
Subject: [PATCH] 1/1 Better expose xenstore limits
Date: Thu, 30 Apr 2009 00:43:03 +0800 [thread overview]
Message-ID: <1241023383.5394.162.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi,
The attached patch announces the limits regarding:
XENSTORE_PAYLOAD_MAX, XENSTORE_ABS_PATH_MAX and XENSTORE_REL_PATH_MAX in
the public xs.h.
These are already defined in xs_wire, however, not many people dig that
far when using xs.h.
Since xs.h already includes xs_wire, this patch duplicates those limits
as XS_PAYLOAD_MAX, XS_ABS_PATH_MAX and XS_REL_PATH_MAX. Moving these
would be a pain, but they really need to be advertised.
Such limits should be obvious in the headers that people actually use
outside of the kernel, saving them from wondering what went wrong.
Added comments direct people to xs_wire.h , in case those limits change.
Signed-off-by: Tim Post <echo@echoreply.us>
[-- Attachment #2: xenstore-expose-limits.patch --]
[-- Type: text/x-patch, Size: 486 bytes --]
diff -r dc5bd14a4675 tools/xenstore/xs.h
--- a/tools/xenstore/xs.h Fri Apr 24 13:46:17 2009 +0100
+++ b/tools/xenstore/xs.h Thu Apr 30 00:39:14 2009 +0800
@@ -23,6 +23,11 @@
#include <xs_lib.h>
#define XBT_NULL 0
+
+/* Please see xen/io/xs_wire.h for more explantion on these limits */
+#define XS_PAYLOAD_MAX XENSTORE_PAYLOAD_MAX
+#define XS_ABS_PATH_MAX XENSTORE_ABS_PATH_MAX
+#define XS_REL_PATH_MAX XENSTORE_REL_PATH_MAX
struct xs_handle;
typedef uint32_t xs_transaction_t;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2009-04-29 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 16:43 Tim Post [this message]
2009-04-29 18:01 ` [PATCH] 1/1 Better expose xenstore limits Keir Fraser
2009-04-29 18:18 ` Tim Post
2009-04-29 21:23 ` Keir Fraser
2009-04-30 8:54 ` Tim Post
2009-04-30 9:35 ` Keir Fraser
2009-04-30 10:02 ` Tim Post
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241023383.5394.162.camel@localhost.localdomain \
--to=echo@echoreply.us \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.