All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/T/D][PATCH 2/2] Linux/Guest cooperative unmapped page cache control
Date: Mon, 14 Jun 2010 10:09:31 -0700	[thread overview]
Message-ID: <1276535371.6437.7417.camel@nimitz> (raw)
In-Reply-To: <20100614165853.GW5191@balbir.in.ibm.com>

On Mon, 2010-06-14 at 22:28 +0530, Balbir Singh wrote:
> If you've got duplicate pages and you know
> that they are duplicated and can be retrieved at a lower cost, why
> wouldn't we go after them first?

I agree with this in theory.  But, the guest lacks the information about
what is truly duplicated and what the costs are for itself and/or the
host to recreate it.  "Unmapped page cache" may be the best proxy that
we have at the moment for "easy to recreate", but I think it's still too
poor a match to make these patches useful.

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/T/D][PATCH 2/2] Linux/Guest cooperative unmapped page cache control
Date: Mon, 14 Jun 2010 10:09:31 -0700	[thread overview]
Message-ID: <1276535371.6437.7417.camel@nimitz> (raw)
In-Reply-To: <20100614165853.GW5191@balbir.in.ibm.com>

On Mon, 2010-06-14 at 22:28 +0530, Balbir Singh wrote:
> If you've got duplicate pages and you know
> that they are duplicated and can be retrieved at a lower cost, why
> wouldn't we go after them first?

I agree with this in theory.  But, the guest lacks the information about
what is truly duplicated and what the costs are for itself and/or the
host to recreate it.  "Unmapped page cache" may be the best proxy that
we have at the moment for "easy to recreate", but I think it's still too
poor a match to make these patches useful.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-06-14 17:09 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 15:51 [RFC/T/D][PATCH 0/2] KVM page cache optimization (v2) Balbir Singh
2010-06-08 15:51 ` Balbir Singh
2010-06-08 15:51 ` [RFC][PATCH 1/2] Linux/Guest unmapped page cache control Balbir Singh
2010-06-08 15:51   ` Balbir Singh
2010-06-13 18:31   ` Balbir Singh
2010-06-13 18:31     ` Balbir Singh
2010-06-14  0:28     ` KAMEZAWA Hiroyuki
2010-06-14  0:28       ` KAMEZAWA Hiroyuki
2010-06-14  6:49       ` Balbir Singh
2010-06-14  6:49         ` Balbir Singh
2010-06-14  7:00         ` KAMEZAWA Hiroyuki
2010-06-14  7:00           ` KAMEZAWA Hiroyuki
2010-06-14  7:36           ` Balbir Singh
2010-06-14  7:36             ` Balbir Singh
2010-06-14  7:49             ` KAMEZAWA Hiroyuki
2010-06-14  7:49               ` KAMEZAWA Hiroyuki
2010-06-08 15:51 ` [RFC/T/D][PATCH 2/2] Linux/Guest cooperative " Balbir Singh
2010-06-08 15:51   ` Balbir Singh
2010-06-10  9:43   ` Avi Kivity
2010-06-10  9:43     ` Avi Kivity
2010-06-10 14:25     ` Balbir Singh
2010-06-10 14:25       ` Balbir Singh
2010-06-11  0:07       ` Dave Hansen
2010-06-11  0:07         ` Dave Hansen
2010-06-11  1:54         ` KAMEZAWA Hiroyuki
2010-06-11  1:54           ` KAMEZAWA Hiroyuki
2010-06-11  4:46           ` Balbir Singh
2010-06-11  4:46             ` Balbir Singh
2010-06-11  5:05             ` KAMEZAWA Hiroyuki
2010-06-11  5:05               ` KAMEZAWA Hiroyuki
2010-06-11  5:08               ` KAMEZAWA Hiroyuki
2010-06-11  5:08                 ` KAMEZAWA Hiroyuki
2010-06-11  6:14               ` Balbir Singh
2010-06-11  6:14                 ` Balbir Singh
2010-06-11  4:56         ` Balbir Singh
2010-06-11  4:56           ` Balbir Singh
2010-06-14  8:09           ` Avi Kivity
2010-06-14  8:09             ` Avi Kivity
2010-06-14  8:48             ` Balbir Singh
2010-06-14  8:48               ` Balbir Singh
2010-06-14 12:40               ` Avi Kivity
2010-06-14 12:40                 ` Avi Kivity
2010-06-14 12:50                 ` Balbir Singh
2010-06-14 12:50                   ` Balbir Singh
2010-06-14 13:01                   ` Avi Kivity
2010-06-14 13:01                     ` Avi Kivity
2010-06-14 15:33                     ` Dave Hansen
2010-06-14 15:33                       ` Dave Hansen
2010-06-14 15:44                       ` Avi Kivity
2010-06-14 15:44                         ` Avi Kivity
2010-06-14 15:55                         ` Dave Hansen
2010-06-14 15:55                           ` Dave Hansen
2010-06-14 16:34                           ` Avi Kivity
2010-06-14 16:34                             ` Avi Kivity
2010-06-14 17:45                             ` Balbir Singh
2010-06-14 17:45                               ` Balbir Singh
2010-06-15  6:58                               ` Avi Kivity
2010-06-15  6:58                                 ` Avi Kivity
2010-06-15  7:49                                 ` Balbir Singh
2010-06-15  7:49                                   ` Balbir Singh
2010-06-15  9:44                                   ` Avi Kivity
2010-06-15  9:44                                     ` Avi Kivity
2010-06-15 10:18                                     ` Balbir Singh
2010-06-15 10:18                                       ` Balbir Singh
2010-06-14 17:58                             ` Dave Hansen
2010-06-14 17:58                               ` Dave Hansen
2010-06-15  7:07                               ` Avi Kivity
2010-06-15  7:07                                 ` Avi Kivity
2010-06-15 14:47                                 ` Dave Hansen
2010-06-15 14:47                                   ` Dave Hansen
2010-06-16 11:39                                   ` Avi Kivity
2010-06-16 11:39                                     ` Avi Kivity
2010-06-17  6:04                                     ` Balbir Singh
2010-06-17  6:04                                       ` Balbir Singh
2010-06-14 15:12               ` Dave Hansen
2010-06-14 15:12                 ` Dave Hansen
2010-06-14 15:34                 ` Avi Kivity
2010-06-14 15:34                   ` Avi Kivity
2010-06-14 17:40                   ` Balbir Singh
2010-06-14 17:40                     ` Balbir Singh
2010-06-15  7:11                     ` Avi Kivity
2010-06-15  7:11                       ` Avi Kivity
2010-06-14 16:58                 ` Balbir Singh
2010-06-14 16:58                   ` Balbir Singh
2010-06-14 17:09                   ` Dave Hansen [this message]
2010-06-14 17:09                     ` Dave Hansen
2010-06-14 17:16                     ` Balbir Singh
2010-06-14 17:16                       ` Balbir Singh
2010-06-15  7:12                       ` Avi Kivity
2010-06-15  7:12                         ` Avi Kivity
2010-06-15  7:52                         ` Balbir Singh
2010-06-15  7:52                           ` Balbir Singh
2010-06-15  9:54                           ` Avi Kivity
2010-06-15  9:54                             ` Avi Kivity
2010-06-15 12:49                             ` Balbir Singh
2010-06-15 12:49                               ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276535371.6437.7417.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=avi@redhat.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.