From: Liam Girdwood <lrg@slimlogic.co.uk>
To: "Eric Bénard" <eric@eukrea.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
s.hauer@pengutronix.de
Subject: Re: [PATCH] eukrea-tlv320: add support for our i.MX25 board
Date: Thu, 17 Jun 2010 15:06:06 +0100 [thread overview]
Message-ID: <1276783566.3070.211.camel@odin> (raw)
In-Reply-To: <1276782241-9407-1-git-send-email-eric@eukrea.com>
On Thu, 2010-06-17 at 15:44 +0200, Eric Bénard wrote:
> * tdm slot has to be configured to get sound working on i.MX25
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> sound/soc/imx/Kconfig | 2 +-
> sound/soc/imx/eukrea-tlv320.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/imx/Kconfig b/sound/soc/imx/Kconfig
> index fd292f1..fd616ae 100644
> --- a/sound/soc/imx/Kconfig
> +++ b/sound/soc/imx/Kconfig
> @@ -31,7 +31,7 @@ config SND_SOC_PHYCORE_AC97
>
> config SND_SOC_EUKREA_TLV320
> bool "Eukrea TLV320"
> - depends on MACH_EUKREA_MBIMX27_BASEBOARD
> + depends on MACH_EUKREA_MBIMX27_BASEBOARD || MACH_EUKREA_MBIMXSD_BASEBOARD
> select SND_MXC_SOC_SSI
> select SND_SOC_TLV320AIC23
> help
> diff --git a/sound/soc/imx/eukrea-tlv320.c b/sound/soc/imx/eukrea-tlv320.c
> index 968380a..45f5e4b 100644
> --- a/sound/soc/imx/eukrea-tlv320.c
> +++ b/sound/soc/imx/eukrea-tlv320.c
> @@ -60,6 +60,7 @@ static int eukrea_tlv320_hw_params(struct snd_pcm_substream *substream,
> pr_err("%s: failed setting codec sysclk\n", __func__);
> return ret;
> }
> + snd_soc_dai_set_tdm_slot(cpu_dai, 0xffffffc, 0xffffffc, 2, 0);
>
> ret = snd_soc_dai_set_sysclk(cpu_dai, IMX_SSP_SYS_CLK, 0,
> SND_SOC_CLOCK_IN);
> @@ -100,7 +101,7 @@ static int __init eukrea_tlv320_init(void)
> {
> int ret;
>
> - if (!machine_is_eukrea_cpuimx27())
> + if (!machine_is_eukrea_cpuimx27() && !machine_is_eukrea_cpuimx25sd())
> /* return happy. We might run on a totally different machine */
> return 0;
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-06-17 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 13:44 [PATCH] eukrea-tlv320: add support for our i.MX25 board Eric Bénard
2010-06-17 14:06 ` Liam Girdwood [this message]
2010-06-18 0:56 ` Mark Brown
2010-06-18 7:10 ` Eric Bénard
2010-06-19 0:29 ` Mark Brown
2010-06-19 8:45 ` Eric Bénard
2010-06-19 11:06 ` Mark Brown
2010-06-19 12:13 ` Eric Bénard
2010-06-20 19:17 ` Eric Bénard
2010-06-19 8:47 ` [PATCH] soc/imx: clean Kconfig Eric Bénard
2010-06-24 11:46 ` Eric Bénard
2010-06-24 11:47 ` Mark Brown
2010-06-24 13:44 ` Liam Girdwood
2010-06-25 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276783566.3070.211.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric@eukrea.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.