From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: alsa-devel@alsa-project.org, s.hauer@pengutronix.de, lrg@slimlogic.co.uk
Subject: Re: [PATCH] eukrea-tlv320: add support for our i.MX25 board
Date: Sat, 19 Jun 2010 01:29:38 +0100 [thread overview]
Message-ID: <20100619002937.GB2463@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4C1B1BE9.9040802@eukrea.com>
On Fri, Jun 18, 2010 at 09:10:33AM +0200, Eric Bénard wrote:
> This Kconfig seems to have unecessary things into it :
> - config SND_MXC_SOC_SSI :
> not used in the kernel
That's supposed to be being used to build the SSI driver as a separate
module.
> - 1st board :
It'd be helpful to use actual names to make your mails legible,
otherwise it's like Outlook style mail.
> depends on SND_IMX_SOC
> select SND_MXC_SOC_SSI
> - 2nd board :
> select SND_MXC_SOC_SSI
> but doesn't depends on SND_IMX_SOC
> - 3rd board :
> select SND_IMX_SOC
>
> Do you have any idea what SND_MXC_SOC_SSI is used for ?
>
> Please find attached a patch which should clean this Kconfig. If
> it's ok for you, I'll submit it the right way.
This isn't the best approach, converting things so SND_IMX_SOC is a menu
and we don't need to reference that at all from the individual items
would be nicer since it saves having to do per-board handling.
next prev parent reply other threads:[~2010-06-19 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 13:44 [PATCH] eukrea-tlv320: add support for our i.MX25 board Eric Bénard
2010-06-17 14:06 ` Liam Girdwood
2010-06-18 0:56 ` Mark Brown
2010-06-18 7:10 ` Eric Bénard
2010-06-19 0:29 ` Mark Brown [this message]
2010-06-19 8:45 ` Eric Bénard
2010-06-19 11:06 ` Mark Brown
2010-06-19 12:13 ` Eric Bénard
2010-06-20 19:17 ` Eric Bénard
2010-06-19 8:47 ` [PATCH] soc/imx: clean Kconfig Eric Bénard
2010-06-24 11:46 ` Eric Bénard
2010-06-24 11:47 ` Mark Brown
2010-06-24 13:44 ` Liam Girdwood
2010-06-25 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100619002937.GB2463@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric@eukrea.com \
--cc=lrg@slimlogic.co.uk \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.