All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, s.hauer@pengutronix.de, lrg@slimlogic.co.uk
Subject: Re: [PATCH] eukrea-tlv320: add support for our i.MX25 board
Date: Sun, 20 Jun 2010 21:17:11 +0200	[thread overview]
Message-ID: <4C1E6937.6050903@eukrea.com> (raw)
In-Reply-To: <20100619110604.GC2409@opensource.wolfsonmicro.com>

Hi Mark,

Le 19/06/2010 13:06, Mark Brown a écrit :
> On Sat, Jun 19, 2010 at 10:45:04AM +0200, Eric Bénard wrote:
>> ok, we can suppose that if someone introduce the possibility to
>> build the SSI driver as a separate module, he will add the right
>> Kconfig option.
>
> This should just be a matter of a simple Makefile edit.
>
OK, I gave this a quick try and it doesn't seem actually possible to 
compile imx-ssi.c as a module without changing some code to separate ssi 
and pcm parts which are actually mixed in imx-ssi.c.
So actually, selecting SND_IMX_SOC as a module produces snd-soc.imx.ko 
which integrates the SSI driver + the PCM drivers.

So actually the 3 following configurations are possible (and tested on 
my i.MX27 board)  with the patch I sent for Kconfig :
- imx soc driver in kernel, board driver in kernel
- imx soc driver in kernel, board driver (snd-soc-eukrea-tlv320.ko) as a 
module
- imx soc driver (snd-soc-imx.ko) and board driver 
(snd-soc-eukrea-tlv320.ko) as 2 modules.

Also thanks for suggesting this Makefile edit, this allowed me to fix 
sound support for my board when soc is compiled as a module ;-)

Eric

  parent reply	other threads:[~2010-06-20 19:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 13:44 [PATCH] eukrea-tlv320: add support for our i.MX25 board Eric Bénard
2010-06-17 14:06 ` Liam Girdwood
2010-06-18  0:56 ` Mark Brown
2010-06-18  7:10   ` Eric Bénard
2010-06-19  0:29     ` Mark Brown
2010-06-19  8:45       ` Eric Bénard
2010-06-19 11:06         ` Mark Brown
2010-06-19 12:13           ` Eric Bénard
2010-06-20 19:17           ` Eric Bénard [this message]
2010-06-19  8:47       ` [PATCH] soc/imx: clean Kconfig Eric Bénard
2010-06-24 11:46         ` Eric Bénard
2010-06-24 11:47           ` Mark Brown
2010-06-24 13:44             ` Liam Girdwood
2010-06-25 11:32         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1E6937.6050903@eukrea.com \
    --to=eric@eukrea.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.