Re: [PATCH] eukrea-tlv320: add support for our i.MX25 board

["Eric Bénard" <eric@eukrea.com>]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hi Mark,

Le 18/06/2010 02:56, Mark Brown a écrit :
> On Thu, Jun 17, 2010 at 03:44:01PM +0200, Eric Bénard wrote:
>> * tdm slot has to be configured to get sound working on i.MX25
>>
>> Signed-off-by: Eric Bénard<eric@eukrea.com>
>
> Applied but I had to hand apply the Kconfig update, please check that it
> applied correctly.
>
Yes this seems fine, sorry I wasn't rebased against the right tree.

This Kconfig seems to have unecessary things into it :
- config SND_MXC_SOC_SSI :
	not used in the kernel
- 1st board :
	depends on SND_IMX_SOC
	select SND_MXC_SOC_SSI
- 2nd board :
	select SND_MXC_SOC_SSI
	but doesn't depends on SND_IMX_SOC
- 3rd board :
	select SND_IMX_SOC

Do you have any idea what SND_MXC_SOC_SSI is used for ?

Please find attached a patch which should clean this Kconfig. If it's ok 
for you, I'll submit it the right way.

Eric

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-soc-imx-clean-Kconfig.patch --]
[-- Type: text/x-patch; name="0001-soc-imx-clean-Kconfig.patch", Size: 1853 bytes --]

>From e177e758ad220e5f77d8321731e89f5b8b5da337 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Eric=20B=C3=A9nard?= <eric@eukrea.com>
Date: Fri, 18 Jun 2010 09:06:45 +0200
Subject: [PATCH] soc/imx: clean Kconfig
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 sound/soc/imx/Kconfig |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/sound/soc/imx/Kconfig b/sound/soc/imx/Kconfig
index 6ef57e0..35e6cf6 100644
--- a/sound/soc/imx/Kconfig
+++ b/sound/soc/imx/Kconfig
@@ -8,22 +8,17 @@ config SND_IMX_SOC
 	  Say Y or M if you want to add support for codecs attached to
 	  the i.MX SSI interface.
 
-config SND_MXC_SOC_SSI
-	tristate
-
 config SND_MXC_SOC_WM1133_EV1
 	tristate "Audio on the the i.MX31ADS with WM1133-EV1 fitted"
 	depends on SND_IMX_SOC && MACH_MX31ADS_WM1133_EV1 && EXPERIMENTAL
 	select SND_SOC_WM8350
-	select SND_MXC_SOC_SSI
 	help
 	  Enable support for audio on the i.MX31ADS with the WM1133-EV1
 	  PMIC board with WM8835x fitted.
 
 config SND_SOC_PHYCORE_AC97
 	tristate "SoC Audio support for Phytec phyCORE (and phyCARD) boards"
-	depends on MACH_PCM043 || MACH_PCA100
-	select SND_MXC_SOC_SSI
+	depends on SND_IMX_SOC && (MACH_PCM043 || MACH_PCA100)
 	select SND_SOC_WM9712
 	help
 	  Say Y if you want to add support for SoC audio on Phytec phyCORE
@@ -31,8 +26,7 @@ config SND_SOC_PHYCORE_AC97
 
 config SND_SOC_EUKREA_TLV320
 	bool "Eukrea TLV320"
-	depends on MACH_EUKREA_MBIMX27_BASEBOARD || MACH_EUKREA_MBIMXSD_BASEBOARD
-	select SND_IMX_SOC
+	depends on SND_IMX_SOC && (MACH_EUKREA_MBIMX27_BASEBOARD || MACH_EUKREA_MBIMXSD_BASEBOARD)
 	select SND_SOC_TLV320AIC23
 	help
 	  Enable I2S based access to the TLV320AIC23B codec attached
-- 
1.6.3.3


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel