Re: [PATCH] eukrea-tlv320: add support for our i.MX25 board

["Eric Bénard" <eric@eukrea.com>]

Le 19/06/2010 02:29, Mark Brown a écrit :
> On Fri, Jun 18, 2010 at 09:10:33AM +0200, Eric Bénard wrote:
>> This Kconfig seems to have unecessary things into it :
>> - config SND_MXC_SOC_SSI :
>> 	not used in the kernel
>
> That's supposed to be being used to build the SSI driver as a separate
> module.
>
ok, we can suppose that if someone introduce the possibility to build 
the SSI driver as a separate module, he will add the right Kconfig option.

>> - 1st board :
>
> It'd be helpful to use actual names to make your mails legible,
> otherwise it's like Outlook style mail.
>
I don't understand what you mean here. What is "Outlook style mail" ?

>> Please find attached a patch which should clean this Kconfig. If
>> it's ok for you, I'll submit it the right way.
>
> This isn't the best approach, converting things so SND_IMX_SOC is a menu
> and we don't need to reference that at all from the individual items
> would be nicer since it saves having to do per-board handling.

OK, if I understood correctly what you mean here, the following patch 
should be better.

Thanks,
Eric