All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: dm-devel@redhat.com, snitzer@redhat.com
Subject: [PATCHSET] dm: update workqueue usages
Date: Sun, 12 Dec 2010 20:10:49 +0100	[thread overview]
Message-ID: <1292181055-25696-1-git-send-email-tj@kernel.org> (raw)

Hello,

This patchset updates workqueue usages in dm and contains the
following six patches.

 0001-dm-stripe-drop-kstriped.patch
 0002-dm-snap-kill-unused-dm_snapshot-queued_bios_work-and.patch
 0003-dm-snap-convert-to-alloc-_ordered-_workqueue.patch
 0004-dm-don-t-use-flush_scheduled_work.patch
 0005-dm-use-non-reentrant-workqueues-if-equivalent.patch
 0006-dm-snap-persistent-make-metadata_wq-multithreaded.patch

0001-0002 drop unnecessary workqueues.  0003-0004 conver to the new
APIs.  0005-0006 relax ordering requirement of some workqueues.

All patches in this series shouldn't introduce any noticeable
difference in work execution ordering.  I stayed away from more
difficult ones like...

* Can the workqueues converted by 0005 be multithreaded instead of
  non-reentrant?

* Does dm-mpath::kmpath_handlerd need WQ_RESCUER?  I suspect not but
  not sure.  If not, it can be dropped and system_wq or kmultipathd
  can be used instead.  Another curious thing here is that while
  activate_path work is queued to kmpath_handlerd, deactivate_path is
  queued to kmultipathd.  Is this intentional?  If so, it might be a
  good idea to comment why it's done that way as it's a bit confusing.

* I'm pretty sure workqueues in dm-crypt would benefit from using
  multithreaded workqueue but people already seem to be working on it
  so I left it alone.

This patchset is on top of 2.6.37-rc5 (6313e3c2).  If it needs to be
against a different tree, please let me know.  The patches are also
available in the following git tree.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git update-dm

and contains the following changes.  Thanks.

 drivers/md/dm-crypt.c           |    4 ++--
 drivers/md/dm-delay.c           |    2 +-
 drivers/md/dm-kcopyd.c          |    3 ++-
 drivers/md/dm-mpath.c           |    7 ++++---
 drivers/md/dm-raid1.c           |    5 +++--
 drivers/md/dm-snap-persistent.c |    4 ++--
 drivers/md/dm-snap.c            |   38 --------------------------------------
 drivers/md/dm-stripe.c          |   25 ++++++-------------------
 drivers/md/dm.c                 |    3 ++-
 9 files changed, 22 insertions(+), 69 deletions(-)

--
tejun

             reply	other threads:[~2010-12-12 19:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-12 19:10 Tejun Heo [this message]
2010-12-12 19:10 ` [PATCH 1/6] dm-stripe: drop kstriped Tejun Heo
2010-12-14 23:59   ` Mike Snitzer
2010-12-15  1:34     ` Mike Snitzer
2011-01-07 23:02       ` Alasdair G Kergon
2011-01-08 17:16         ` Tejun Heo
2010-12-12 19:10 ` [PATCH 2/6] dm-snap: kill unused dm_snapshot->queued_bios_work and ksnapd Tejun Heo
2010-12-12 19:10 ` [PATCH 3/6] dm-snap: convert to alloc[_ordered]_workqueue() Tejun Heo
2010-12-12 19:10 ` [PATCH 4/6] dm: don't use flush_scheduled_work() Tejun Heo
2010-12-12 19:10 ` [PATCH 5/6] dm: use non-reentrant workqueues if equivalent Tejun Heo
2010-12-12 19:10 ` [PATCH 6/6] dm-snap-persistent: make metadata_wq multithreaded Tejun Heo
2011-01-08  3:31   ` Mikulas Patocka
2010-12-12 21:23 ` [PATCHSET] dm: update workqueue usages Milan Broz
2010-12-14 15:49   ` Tejun Heo
2010-12-14 16:03     ` Mike Snitzer
2010-12-14 16:05       ` Tejun Heo
2010-12-20 14:14         ` Mike Snitzer
2010-12-20 16:03           ` Tejun Heo
2010-12-14 12:19 ` [PATCHSET] " Heinz Mauelshagen
2010-12-14 13:16   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292181055-25696-1-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=dm-devel@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.