All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: dm-devel@redhat.com, snitzer@redhat.com
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 6/6] dm-snap-persistent: make metadata_wq multithreaded
Date: Sun, 12 Dec 2010 20:10:55 +0100	[thread overview]
Message-ID: <1292181055-25696-7-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1292181055-25696-1-git-send-email-tj@kernel.org>

metadata_wq serves on-stack work items from chunk_io().  Even if
multiple chunk_io() are simultaneously in progress, each is
independent and queued only once, so multithreaded workqueue can be
safely used.

Switch metadata_wq to multithread and flush the work item instead of
the workqueue in chunk_io().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com
---
 drivers/md/dm-snap-persistent.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/md/dm-snap-persistent.c b/drivers/md/dm-snap-persistent.c
index d3021a6..95891df 100644
--- a/drivers/md/dm-snap-persistent.c
+++ b/drivers/md/dm-snap-persistent.c
@@ -256,7 +256,7 @@ static int chunk_io(struct pstore *ps, void *area, chunk_t chunk, int rw,
 	 */
 	INIT_WORK_ONSTACK(&req.work, do_metadata);
 	queue_work(ps->metadata_wq, &req.work);
-	flush_workqueue(ps->metadata_wq);
+	flush_work(&req.work);
 
 	return req.result;
 }
@@ -818,7 +818,7 @@ static int persistent_ctr(struct dm_exception_store *store,
 	atomic_set(&ps->pending_count, 0);
 	ps->callbacks = NULL;
 
-	ps->metadata_wq = alloc_ordered_workqueue("ksnaphd", WQ_MEM_RECLAIM);
+	ps->metadata_wq = alloc_workqueue("ksnaphd", WQ_MEM_RECLAIM, 0);
 	if (!ps->metadata_wq) {
 		kfree(ps);
 		DMERR("couldn't start header metadata update thread");
-- 
1.7.1

  parent reply	other threads:[~2010-12-12 19:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-12 19:10 [PATCHSET] dm: update workqueue usages Tejun Heo
2010-12-12 19:10 ` [PATCH 1/6] dm-stripe: drop kstriped Tejun Heo
2010-12-14 23:59   ` Mike Snitzer
2010-12-15  1:34     ` Mike Snitzer
2011-01-07 23:02       ` Alasdair G Kergon
2011-01-08 17:16         ` Tejun Heo
2010-12-12 19:10 ` [PATCH 2/6] dm-snap: kill unused dm_snapshot->queued_bios_work and ksnapd Tejun Heo
2010-12-12 19:10 ` [PATCH 3/6] dm-snap: convert to alloc[_ordered]_workqueue() Tejun Heo
2010-12-12 19:10 ` [PATCH 4/6] dm: don't use flush_scheduled_work() Tejun Heo
2010-12-12 19:10 ` [PATCH 5/6] dm: use non-reentrant workqueues if equivalent Tejun Heo
2010-12-12 19:10 ` Tejun Heo [this message]
2011-01-08  3:31   ` [PATCH 6/6] dm-snap-persistent: make metadata_wq multithreaded Mikulas Patocka
2010-12-12 21:23 ` [PATCHSET] dm: update workqueue usages Milan Broz
2010-12-14 15:49   ` Tejun Heo
2010-12-14 16:03     ` Mike Snitzer
2010-12-14 16:05       ` Tejun Heo
2010-12-20 14:14         ` Mike Snitzer
2010-12-20 16:03           ` Tejun Heo
2010-12-14 12:19 ` [PATCHSET] " Heinz Mauelshagen
2010-12-14 13:16   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292181055-25696-7-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=dm-devel@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.