From: Mike Snitzer <snitzer@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 1/6] dm-stripe: drop kstriped
Date: Tue, 14 Dec 2010 18:59:35 -0500 [thread overview]
Message-ID: <20101214235935.GB14227@redhat.com> (raw)
In-Reply-To: <1292181055-25696-2-git-send-email-tj@kernel.org>
On Sun, Dec 12 2010 at 2:10pm -0500,
Tejun Heo <tj@kernel.org> wrote:
> kstriped only serves sc->kstriped_ws which runs dm_table_event().
> This doesn't need to be executed from an ordered workqueue w/ rescuer.
> Drop kstriped and use the system_wq instead.
What might look unnecessary at first glance is a bit more nuanced than
we'd both like...
I'm concerned about switching to using the global system_wq and calling
flush_scheduled_work() when resuming a DM table (calls a DM target's
->dtr() via dm_table_destroy in drivers/md/dm-ioctl.c:do_resume).
This introduces potential for a DM table swap performing a storm of
additional unrelated works.
Definitely needs further review.
Mike
next prev parent reply other threads:[~2010-12-14 23:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 19:10 [PATCHSET] dm: update workqueue usages Tejun Heo
2010-12-12 19:10 ` [PATCH 1/6] dm-stripe: drop kstriped Tejun Heo
2010-12-14 23:59 ` Mike Snitzer [this message]
2010-12-15 1:34 ` Mike Snitzer
2011-01-07 23:02 ` Alasdair G Kergon
2011-01-08 17:16 ` Tejun Heo
2010-12-12 19:10 ` [PATCH 2/6] dm-snap: kill unused dm_snapshot->queued_bios_work and ksnapd Tejun Heo
2010-12-12 19:10 ` [PATCH 3/6] dm-snap: convert to alloc[_ordered]_workqueue() Tejun Heo
2010-12-12 19:10 ` [PATCH 4/6] dm: don't use flush_scheduled_work() Tejun Heo
2010-12-12 19:10 ` [PATCH 5/6] dm: use non-reentrant workqueues if equivalent Tejun Heo
2010-12-12 19:10 ` [PATCH 6/6] dm-snap-persistent: make metadata_wq multithreaded Tejun Heo
2011-01-08 3:31 ` Mikulas Patocka
2010-12-12 21:23 ` [PATCHSET] dm: update workqueue usages Milan Broz
2010-12-14 15:49 ` Tejun Heo
2010-12-14 16:03 ` Mike Snitzer
2010-12-14 16:05 ` Tejun Heo
2010-12-20 14:14 ` Mike Snitzer
2010-12-20 16:03 ` Tejun Heo
2010-12-14 12:19 ` [PATCHSET] " Heinz Mauelshagen
2010-12-14 13:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214235935.GB14227@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.