From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@gmail.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] block: use static bio_set for bio_split() calls
Date: Wed, 24 Apr 2019 12:49:11 -0700 [thread overview]
Message-ID: <1556135351.161891.138.camel@acm.org> (raw)
In-Reply-To: <20190418140632.60606-1-hare@suse.de>
On Thu, 2019-04-18 at 16:06 +0200, Hannes Reinecke wrote:
> +static int __init blk_bio_split_init(void)
> +{
> + return bioset_init(&bio_split_bio_set, BIO_POOL_SIZE, 0,
> + BIOSET_NEED_BVECS);
> +}
The slab allocator uses __init for some of its initialization. Can it happen
that blk_bio_split_init() is called before slab initialization has finished?
Otherwise this patch looks fine to me.
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: bvanassche@acm.org (Bart Van Assche)
Subject: [PATCH] block: use static bio_set for bio_split() calls
Date: Wed, 24 Apr 2019 12:49:11 -0700 [thread overview]
Message-ID: <1556135351.161891.138.camel@acm.org> (raw)
In-Reply-To: <20190418140632.60606-1-hare@suse.de>
On Thu, 2019-04-18@16:06 +0200, Hannes Reinecke wrote:
> +static int __init blk_bio_split_init(void)
> +{
> + return bioset_init(&bio_split_bio_set, BIO_POOL_SIZE, 0,
> + BIOSET_NEED_BVECS);
> +}
The slab allocator uses __init for some of its initialization. Can it happen
that blk_bio_split_init() is called before slab initialization has finished?
Otherwise this patch looks fine to me.
Bart.
next prev parent reply other threads:[~2019-04-24 19:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 14:06 [PATCH] block: use static bio_set for bio_split() calls Hannes Reinecke
2019-04-18 14:06 ` Hannes Reinecke
2019-04-18 14:34 ` Ming Lei
2019-04-18 14:34 ` Ming Lei
2019-04-18 15:02 ` Hannes Reinecke
2019-04-18 15:02 ` Hannes Reinecke
2019-04-18 18:26 ` Edmund Nadolski (Microsoft)
2019-04-18 18:26 ` Edmund Nadolski (Microsoft)
2019-04-24 17:20 ` Sagi Grimberg
2019-04-24 17:20 ` Sagi Grimberg
2019-04-24 18:56 ` Hannes Reinecke
2019-04-24 18:56 ` Hannes Reinecke
2019-04-24 18:58 ` Sagi Grimberg
2019-04-24 18:58 ` Sagi Grimberg
2019-04-24 22:14 ` Ming Lei
2019-04-24 22:14 ` Ming Lei
2019-04-25 0:41 ` Ming Lei
2019-04-25 0:41 ` Ming Lei
2019-04-25 14:32 ` Hannes Reinecke
2019-04-25 14:32 ` Hannes Reinecke
2019-04-25 15:36 ` Ming Lei
2019-04-25 15:36 ` Ming Lei
2019-04-30 11:48 ` Hannes Reinecke
2019-04-30 11:48 ` Hannes Reinecke
2019-04-24 19:49 ` Bart Van Assche [this message]
2019-04-24 19:49 ` Bart Van Assche
2019-04-25 6:06 ` Hannes Reinecke
2019-04-25 6:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556135351.161891.138.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.