From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
Bart van Assche <bvanassche@acm.org>,
Ming Lei <ming.lei@gmail.com>,
neilb@suse.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: use static bio_set for bio_split() calls
Date: Wed, 24 Apr 2019 11:58:21 -0700 [thread overview]
Message-ID: <7588161e-deea-0009-0f53-7f0cd7295fc2@grimberg.me> (raw)
In-Reply-To: <69845bdb-cfc6-58d4-4fea-b06c2dd44872@suse.de>
> Phew. I was wondering whether I'd been too stupid to find it.
> And having looked at it a bit closer, moving the bioset into the holding
> structure would induce more churn, as we'd need to pass the bioset into
> blk_queue_split(), which would mean to update all drivers (11 in total)
> for no real gain IMO; bio splitting shouldn't really be a regular
> occurrence and hence the bioset should only be used infrequently.
>
> However, I really would like to get feedback to the actual patch, as
> this solves a real customer issues we've had (or still have, depending
> on the view :-)
I think that the patch is good, which is why I asked Ming to provide
more info...
WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] block: use static bio_set for bio_split() calls
Date: Wed, 24 Apr 2019 11:58:21 -0700 [thread overview]
Message-ID: <7588161e-deea-0009-0f53-7f0cd7295fc2@grimberg.me> (raw)
In-Reply-To: <69845bdb-cfc6-58d4-4fea-b06c2dd44872@suse.de>
> Phew. I was wondering whether I'd been too stupid to find it.
> And having looked at it a bit closer, moving the bioset into the holding
> structure would induce more churn, as we'd need to pass the bioset into
> blk_queue_split(), which would mean to update all drivers (11 in total)
> for no real gain IMO; bio splitting shouldn't really be a regular
> occurrence and hence the bioset should only be used infrequently.
>
> However, I really would like to get feedback to the actual patch, as
> this solves a real customer issues we've had (or still have, depending
> on the view :-)
I think that the patch is good, which is why I asked Ming to provide
more info...
next prev parent reply other threads:[~2019-04-24 18:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 14:06 [PATCH] block: use static bio_set for bio_split() calls Hannes Reinecke
2019-04-18 14:06 ` Hannes Reinecke
2019-04-18 14:34 ` Ming Lei
2019-04-18 14:34 ` Ming Lei
2019-04-18 15:02 ` Hannes Reinecke
2019-04-18 15:02 ` Hannes Reinecke
2019-04-18 18:26 ` Edmund Nadolski (Microsoft)
2019-04-18 18:26 ` Edmund Nadolski (Microsoft)
2019-04-24 17:20 ` Sagi Grimberg
2019-04-24 17:20 ` Sagi Grimberg
2019-04-24 18:56 ` Hannes Reinecke
2019-04-24 18:56 ` Hannes Reinecke
2019-04-24 18:58 ` Sagi Grimberg [this message]
2019-04-24 18:58 ` Sagi Grimberg
2019-04-24 22:14 ` Ming Lei
2019-04-24 22:14 ` Ming Lei
2019-04-25 0:41 ` Ming Lei
2019-04-25 0:41 ` Ming Lei
2019-04-25 14:32 ` Hannes Reinecke
2019-04-25 14:32 ` Hannes Reinecke
2019-04-25 15:36 ` Ming Lei
2019-04-25 15:36 ` Ming Lei
2019-04-30 11:48 ` Hannes Reinecke
2019-04-30 11:48 ` Hannes Reinecke
2019-04-24 19:49 ` Bart Van Assche
2019-04-24 19:49 ` Bart Van Assche
2019-04-25 6:06 ` Hannes Reinecke
2019-04-25 6:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7588161e-deea-0009-0f53-7f0cd7295fc2@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@gmail.com \
--cc=ming.lei@redhat.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.