From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.com>,
Bart van Assche <bvanassche@acm.org>,
Ming Lei <ming.lei@gmail.com>,
neilb@suse.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [PATCH] block: use static bio_set for bio_split() calls
Date: Thu, 25 Apr 2019 06:14:23 +0800 [thread overview]
Message-ID: <20190424221422.GA21351@ming.t460p> (raw)
In-Reply-To: <98d8549a-2663-b404-e38a-6f55dfb575bf@grimberg.me>
On Wed, Apr 24, 2019 at 10:20:46AM -0700, Sagi Grimberg wrote:
>
> > per-queue bioset is used originally for avoiding deadlock, are you
> > sure the static bioset is safe?
>
> Can you explain this? I didn't find any indication of that in the change
> log history...
>
> Originally introduced by Kent:
bio split can be run from stacking drivers, for example, MD over NVMe,
if the global reserved mempool is consumed by MD bio splitting, then
no any progress can be made when splitting on bio submitted to NVMe.
Kent may have more details...
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH] block: use static bio_set for bio_split() calls
Date: Thu, 25 Apr 2019 06:14:23 +0800 [thread overview]
Message-ID: <20190424221422.GA21351@ming.t460p> (raw)
In-Reply-To: <98d8549a-2663-b404-e38a-6f55dfb575bf@grimberg.me>
On Wed, Apr 24, 2019@10:20:46AM -0700, Sagi Grimberg wrote:
>
> > per-queue bioset is used originally for avoiding deadlock, are you
> > sure the static bioset is safe?
>
> Can you explain this? I didn't find any indication of that in the change
> log history...
>
> Originally introduced by Kent:
bio split can be run from stacking drivers, for example, MD over NVMe,
if the global reserved mempool is consumed by MD bio splitting, then
no any progress can be made when splitting on bio submitted to NVMe.
Kent may have more details...
Thanks,
Ming
next prev parent reply other threads:[~2019-04-24 22:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 14:06 [PATCH] block: use static bio_set for bio_split() calls Hannes Reinecke
2019-04-18 14:06 ` Hannes Reinecke
2019-04-18 14:34 ` Ming Lei
2019-04-18 14:34 ` Ming Lei
2019-04-18 15:02 ` Hannes Reinecke
2019-04-18 15:02 ` Hannes Reinecke
2019-04-18 18:26 ` Edmund Nadolski (Microsoft)
2019-04-18 18:26 ` Edmund Nadolski (Microsoft)
2019-04-24 17:20 ` Sagi Grimberg
2019-04-24 17:20 ` Sagi Grimberg
2019-04-24 18:56 ` Hannes Reinecke
2019-04-24 18:56 ` Hannes Reinecke
2019-04-24 18:58 ` Sagi Grimberg
2019-04-24 18:58 ` Sagi Grimberg
2019-04-24 22:14 ` Ming Lei [this message]
2019-04-24 22:14 ` Ming Lei
2019-04-25 0:41 ` Ming Lei
2019-04-25 0:41 ` Ming Lei
2019-04-25 14:32 ` Hannes Reinecke
2019-04-25 14:32 ` Hannes Reinecke
2019-04-25 15:36 ` Ming Lei
2019-04-25 15:36 ` Ming Lei
2019-04-30 11:48 ` Hannes Reinecke
2019-04-30 11:48 ` Hannes Reinecke
2019-04-24 19:49 ` Bart Van Assche
2019-04-24 19:49 ` Bart Van Assche
2019-04-25 6:06 ` Hannes Reinecke
2019-04-25 6:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424221422.GA21351@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@gmail.com \
--cc=neilb@suse.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.