Re: [PATCH 4/x] sunhme: switch to devres

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

Am Freitag, 29. Juli 2022, 02:33:01 CEST schrieb Sean Anderson:
> On 7/28/22 3:52 PM, Rolf Eike Beer wrote:
> > Am 2022-07-27 05:58, schrieb Sean Anderson:
> >> On 7/26/22 11:49 PM, Sean Anderson wrote:
> >>> This looks good, but doesn't apply cleanly. I rebased it as follows:
> > Looks like what my local rebase has also produced.
> > 
> > The sentence about the leak from the commitmessage can be dropped then,
> > as this leak has already been fixed.
> > 
> >>> diff --git a/drivers/net/ethernet/sun/sunhme.c
> >>> b/drivers/net/ethernet/sun/sunhme.c index eebe8c5f480c..e83774ffaa7a
> >>> 100644
> >>> --- a/drivers/net/ethernet/sun/sunhme.c
> >>> +++ b/drivers/net/ethernet/sun/sunhme.c
> >>> @@ -2990,21 +2990,23 @@ static int happy_meal_pci_probe(struct pci_dev
> >>> *pdev, qp->happy_meals[qfe_slot] = dev;
> >>>       }
> >>> 
> >>> -    hpreg_res = pci_resource_start(pdev, 0);
> >>> -    err = -ENODEV;
> >>>       if ((pci_resource_flags(pdev, 0) & IORESOURCE_IO) != 0) {
> >>>           printk(KERN_ERR "happymeal(PCI): Cannot find proper PCI device
> >>> base address.\n"); goto err_out_clear_quattro;
> >>>       }
> >>> -    if (pci_request_regions(pdev, DRV_NAME)) {
> >>> +
> >>> +    if (!devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),
> >>> +                  pci_resource_len(pdev, 0),
> >>> +                  DRV_NAME)) {
> >> 
> >> Actually, it looks like you are failing to set err from these *m
> >> calls, like what
> >> you fixed in patch 3. Can you address this for v2?
> > 
> > It returns NULL on error, there is no error code I can set.
> 
> So it does. A quick grep shows that most drivers return -EBUSY.

Sure, I just meant that there is no error code I can pass on. I can change 
that to -EBUSY if you prefer that, currently it just returns -ENODEV as the 
old code has done before.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]