All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: netdev@vger.kernel.org
Subject: [PATCH 3/3] sunhme: forward the error code from pci_enable_device()
Date: Thu, 03 Feb 2022 17:23:54 +0100	[thread overview]
Message-ID: <8022143.T7Z3S40VBb@eto.sf-tec.de> (raw)
In-Reply-To: <4686583.GXAFRqVoOG@eto.sf-tec.de>

This already returns a proper error value, so pass it to the caller.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
 drivers/net/ethernet/sun/sunhme.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index 43834339bb43..980a936ce8d1 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -2969,11 +2969,12 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
 		strcpy(prom_name, "SUNW,hme");
 #endif
 
-	err = -ENODEV;
+	err = pci_enable_device(pdev);
 
-	if (pci_enable_device(pdev))
+	if (err)
 		goto err_out;
 	pci_set_master(pdev);
+	err = -ENODEV;
 
 	if (!strcmp(prom_name, "SUNW,qfe") || !strcmp(prom_name, "qfe")) {
 		qp = quattro_pci_find(pdev);
-- 
2.31.1





  parent reply	other threads:[~2022-02-03 16:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03 16:20 sunhme: some cleanups Rolf Eike Beer
2022-02-03 16:21 ` [PATCH 1/3] sunhme: remove unused tx_dump_ring() Rolf Eike Beer
2022-07-27  3:42   ` Sean Anderson
2022-02-03 16:22 ` [PATCH 2/3] sunhme: fix the version number in struct ethtool_drvinfo Rolf Eike Beer
2022-02-03 17:12   ` Andrew Lunn
2022-02-05 11:27     ` Rolf Eike Beer
2022-02-05 14:48       ` Andrew Lunn
2022-02-05 15:57         ` Rolf Eike Beer
2022-02-05 16:32           ` Andrew Lunn
2022-02-03 21:53   ` Jakub Kicinski
2022-02-14 18:33   ` [PATCH 2/3 v2] " Rolf Eike Beer
2022-02-03 16:23 ` Rolf Eike Beer [this message]
2022-07-27  3:48   ` [PATCH 3/3] sunhme: forward the error code from pci_enable_device() Sean Anderson
2022-02-14 18:31 ` [PATCH 4/x] sunhme: switch to devres Rolf Eike Beer
2022-07-27  3:49   ` Sean Anderson
2022-07-27  3:58     ` Sean Anderson
2022-07-28 19:52       ` Rolf Eike Beer
2022-07-29  0:33         ` Sean Anderson
2022-08-01 15:14           ` Rolf Eike Beer
2022-08-24 15:45             ` Rolf Eike Beer
2022-08-24 15:57               ` Sean Anderson
2022-08-29 13:22   ` [PATCH 4/4 v2] " Rolf Eike Beer
2022-08-30  0:16     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8022143.T7Z3S40VBb@eto.sf-tec.de \
    --to=eike-kernel@sf-tec.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.