Re: [PATCH 2/3] sunhme: fix the version number in struct ethtool_drvinfo

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

Am Donnerstag, 3. Februar 2022, 18:12:40 CET schrieb Andrew Lunn:
> On Thu, Feb 03, 2022 at 05:22:23PM +0100, Rolf Eike Beer wrote:
> > Fixes: 050bbb196392b9c178f82b1205a23dd2f915ee93
> > Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> > ---
> > 
> >  drivers/net/ethernet/sun/sunhme.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/sun/sunhme.c
> > b/drivers/net/ethernet/sun/sunhme.c index 22abfe58f728..43834339bb43
> > 100644
> > --- a/drivers/net/ethernet/sun/sunhme.c
> > +++ b/drivers/net/ethernet/sun/sunhme.c
> > @@ -2470,8 +2470,8 @@ static void hme_get_drvinfo(struct net_device *dev,
> > struct ethtool_drvinfo *info> 
> >  {
> >  
> >  	struct happy_meal *hp = netdev_priv(dev);
> > 
> > -	strlcpy(info->driver, "sunhme", sizeof(info->driver));
> > -	strlcpy(info->version, "2.02", sizeof(info->version));
> > +	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
> > +	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
> 
> I would suggest you drop setting info->version. The kernel will fill
> it with the current kernel version, which is much more meaningful.

Would it make sense to completely remove the version number from the driver 
then?

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]