Bad: scheduling while atomic!

Bad: scheduling while atomic!

[Lukas Schrangl]

Hi!

I've been trying to get S4 working for several weeks now using kernel 2.6.4  
and it still does not work.
Going to sleep with "echo -n 4 > /proc/acpi/sleep" works - but i get some APIC 
error (don't know exactly - can't read that fast).
When powering on again it first start normal, but then there is an endless 
loop displaying "Bad: Scheduling while atomic!" and a call trace again and 
again very fast. I can only hard- poweroff my computer.
Disabling local APIC does not help.

S3 does not wake up either (fan and hd spin up and then silence). Once, with 
minimal kernel configuration I managed to get a picture again on the screen, 
showing the same "Bad: Scheduling while atomic!" thing.

Maybe someone can help me getting S4 working!
Lukas


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

Re: Bad: scheduling while atomic!

[Lukas Schrangl]

Am Mittwoch, 31. März 2004 10:54 schrieb Lukas Schrangl:
> Hi!
>
> I've been trying to get S4 working for several weeks now using kernel 2.6.4
> and it still does not work.
> Going to sleep with "echo -n 4 > /proc/acpi/sleep" works - but i get some
> APIC error (don't know exactly - can't read that fast).
> When powering on again it first start normal, but then there is an endless
> loop displaying "Bad: Scheduling while atomic!" and a call trace again and
> again very fast. I can only hard- poweroff my computer.
> Disabling local APIC does not help.
>
> S3 does not wake up either (fan and hd spin up and then silence). Once,
> with minimal kernel configuration I managed to get a picture again on the
> screen, showing the same "Bad: Scheduling while atomic!" thing.
>
> Maybe someone can help me getting S4 working!
> Lukas

I forgot:
ALi M1533 Chipset
ATI IGP 320M Northbridge
Ahlon XP 2500+ Northbridge
SuSE 9.0
Kernel 2.6.4


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click

Re: Bad: scheduling while atomic!

[Tomasz Ciolek]

 I get the same error with suspend to disk on a Fujitsu P2120. Ali 1535
 chipset is the common bit... 

 Whats the network card you use?

 Tomasz Ciolek

On Wed, Mar 31, 2004 at 11:07:02AM +0200, Lukas Schrangl wrote:
> Am Mittwoch, 31. M?rz 2004 10:54 schrieb Lukas Schrangl:
> > Hi!
> >
> > I've been trying to get S4 working for several weeks now using kernel 2.6.4
> > and it still does not work.
> > Going to sleep with "echo -n 4 > /proc/acpi/sleep" works - but i get some
> > APIC error (don't know exactly - can't read that fast).
> > When powering on again it first start normal, but then there is an endless
> > loop displaying "Bad: Scheduling while atomic!" and a call trace again and
> > again very fast. I can only hard- poweroff my computer.
> > Disabling local APIC does not help.
> >
> > S3 does not wake up either (fan and hd spin up and then silence). Once,
> > with minimal kernel configuration I managed to get a picture again on the
> > screen, showing the same "Bad: Scheduling while atomic!" thing.
> >
> > Maybe someone can help me getting S4 working!
> > Lukas
> 
> I forgot:
> ALi M1533 Chipset
> ATI IGP 320M Northbridge
> Ahlon XP 2500+ Northbridge
> SuSE 9.0
> Kernel 2.6.4
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel

-- 
Tomasz M. Ciolek	
*******************************************************************************
 tmc at dreamcraft dot com dot au or tmc at goldweb dot com dot au 	
*******************************************************************************
	GPG Key ID: 0x41C4C2F0  Key available on www.pgp.net	
*******************************************************************************
  Everything falls under the law of change;	
  Like a dream, a phantom, a bubble, a shadow,
  like dew of flash of lightning.
  You should contemplate like this. 


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click

Re: Bad: scheduling while atomic!

[Lukas Schrangl]

Am Mittwoch, 31. März 2004 15:59 schrieb Tomasz Ciolek:
>  I get the same error with suspend to disk on a Fujitsu P2120. Ali 1535
>  chipset is the common bit...
>
>  Whats the network card you use?
>

Broadcom BCM 4401

>  Tomasz Ciolek
>
> On Wed, Mar 31, 2004 at 11:07:02AM +0200, Lukas Schrangl wrote:
> > Am Mittwoch, 31. M?rz 2004 10:54 schrieb Lukas Schrangl:
> > > Hi!
> > >
> > > I've been trying to get S4 working for several weeks now using kernel
> > > 2.6.4 and it still does not work.
> > > Going to sleep with "echo -n 4 > /proc/acpi/sleep" works - but i get
> > > some APIC error (don't know exactly - can't read that fast).
> > > When powering on again it first start normal, but then there is an
> > > endless loop displaying "Bad: Scheduling while atomic!" and a call
> > > trace again and again very fast. I can only hard- poweroff my computer.
> > > Disabling local APIC does not help.
> > >
> > > S3 does not wake up either (fan and hd spin up and then silence). Once,
> > > with minimal kernel configuration I managed to get a picture again on
> > > the screen, showing the same "Bad: Scheduling while atomic!" thing.
> > >
> > > Maybe someone can help me getting S4 working!
> > > Lukas
> >
> > I forgot:
> > ALi M1533 Chipset
> > ATI IGP 320M Northbridge
> > Ahlon XP 2500+ Northbridge
> > SuSE 9.0
> > Kernel 2.6.4
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: IBM Linux Tutorials
> > Free Linux tutorial presented by Daniel Robbins, President and CEO of
> > GenToo technologies. Learn everything from fundamentals to system
> > administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel

Lukas


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click

Re: Bad: scheduling while atomic!

[Stefan Seyfried]

On Thu, Apr 01, 2004 at 08:46:01AM +0200, Lukas Schrangl wrote:
> Am Mittwoch, 31. März 2004 15:59 schrieb Tomasz Ciolek:
> >  I get the same error with suspend to disk on a Fujitsu P2120. Ali 1535
> >  chipset is the common bit...
> >
> >  Whats the network card you use?
> >
> 
> Broadcom BCM 4401

i need to unload bcm4400 before suspend (swsusp, ACPI S4) and reinsert
after resume, otherwise resume fails. Maybe the same is true for S3.
-- 
Stefan Seyfried



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

Re: Re: Bad: scheduling while atomic!

[Lukas Schrangl]

Am Donnerstag, 1. April 2004 17:07 schrieb Stefan Seyfried:
> On Thu, Apr 01, 2004 at 08:46:01AM +0200, Lukas Schrangl wrote:
> > Am Mittwoch, 31. März 2004 15:59 schrieb Tomasz Ciolek:
> > >  I get the same error with suspend to disk on a Fujitsu P2120. Ali 1535
> > >  chipset is the common bit...
> > >
> > >  Whats the network card you use?
> >
> > Broadcom BCM 4401
>
> i need to unload bcm4400 before suspend (swsusp, ACPI S4) and reinsert
> after resume, otherwise resume fails. Maybe the same is true for S3.

The problem was enabling both preemptible kernel and MCE. Using only one of 
them everything works, even if b44 is inserted and Local APIC enabled.
Only usb makes problems:
On wakeup I get something like
"Badness in usb/hcd/....c"
and a call trace. Will try to resolve that problem (maybe unloading usbmodules 
works, haven't had time to try yet).
After resume, I am not able to use usb anymore (even unloading/realoading 
doesn't work).
And ACPI- poweroff does not work anymore. When shutting down I can read:
"The system will be haltet immediately.
acpi_power_off called"
or something the like, but no nothing happens; i poweroff manually. On 
"normal" shutdowns (when not having resumed from S4) I don't get the msg 
"acpi_power_off called" and it powers off.
Should I write a bug report because of the preempt/MCE problem and/or the APIC 
error which seems not to have any influence?

Lukas


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click

Re: Bad: scheduling while atomic!

[Pavel Machek]

Hi!

> I've been trying to get S4 working for several weeks now using kernel 2.6.4  
> and it still does not work.
> Going to sleep with "echo -n 4 > /proc/acpi/sleep" works - but i get some APIC 
> error (don't know exactly - can't read that fast).
> When powering on again it first start normal, but then there is an endless 
> loop displaying "Bad: Scheduling while atomic!" and a call trace again and 
> again very fast. I can only hard- poweroff my computer.
> Disabling local APIC does not help.

Trun off APIC in kernel config and try without that broadcom network
card.
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

bad: scheduling while atomic!

[Lucas Gadani]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Linux kernel version is vanilla 2.6.3. System is Debian/unstable.

Got the attached trace while I was removing a file from an ext3 fs.

Don't know if this is related, but system was doing a smart long
self-test while got this trace. So, I also attached a dump of "smartctl
-a".

-- 
Lucas

[-- Attachment #2: error.txt --]
[-- Type: text/plain, Size: 3898 bytes --]

EXT3-fs error (device hdb5): ext3_free_blocks: bit already cleared for block 8457254
Aborting journal on device hdb5.
bad: scheduling while atomic!
Call Trace:
 [<c0118c48>] schedule+0x568/0x580
 [<c01d2851>] do_ide_request+0x11/0x20
 [<c01c18df>] generic_unplug_device+0x5f/0x80
 [<c0119b4e>] io_schedule+0xe/0x20
 [<c014dffb>] __wait_on_buffer+0xbb/0xc0
 [<c011a280>] autoremove_wake_function+0x0/0x40
 [<c01c2d35>] submit_bio+0x35/0x80
 [<c011a280>] autoremove_wake_function+0x0/0x40
 [<c015135a>] sync_dirty_buffer+0x3a/0xa0
 [<c018e84c>] journal_update_superblock+0x6c/0xc0
 [<c0185a88>] ext3_handle_error+0x48/0xa0
 [<c0185b18>] ext3_error+0x38/0x40
 [<c017bf37>] ext3_free_blocks+0x3d7/0x480
 [<c0180bbb>] ext3_free_data+0xbb/0x120
 [<c0180ceb>] ext3_free_branches+0xcb/0x1e0
 [<c0180ceb>] ext3_free_branches+0xcb/0x1e0
 [<c0181206>] ext3_truncate+0x406/0x520
 [<c018899f>] journal_start+0x7f/0xc0
 [<c017e9f5>] start_transaction+0x15/0x60
 [<c017eb59>] ext3_delete_inode+0x99/0xe0
 [<c017eac0>] ext3_delete_inode+0x0/0xe0
 [<c0164d41>] generic_delete_inode+0x61/0x100
 [<c0164f78>] iput+0x58/0x80
 [<c015b89d>] sys_unlink+0xdd/0x120
 [<c015d8c9>] sys_ioctl+0xc9/0x260
 [<c010a8a7>] syscall_call+0x7/0xb

bad: scheduling while atomic!
Call Trace:
 [<c0118c48>] schedule+0x568/0x580
 [<c01d2851>] do_ide_request+0x11/0x20
 [<c01c18df>] generic_unplug_device+0x5f/0x80
 [<c01c1a2e>] blk_run_queues+0x6e/0xc0
 [<c0119b4e>] io_schedule+0xe/0x20
 [<c014dffb>] __wait_on_buffer+0xbb/0xc0
 [<c011a280>] autoremove_wake_function+0x0/0x40
 [<c01c2d35>] submit_bio+0x35/0x80
 [<c011a280>] autoremove_wake_function+0x0/0x40
 [<c015135a>] sync_dirty_buffer+0x3a/0xa0
 [<c0185a93>] ext3_handle_error+0x53/0xa0
 [<c0185b18>] ext3_error+0x38/0x40
 [<c017bf37>] ext3_free_blocks+0x3d7/0x480
 [<c0180bbb>] ext3_free_data+0xbb/0x120
 [<c0180ceb>] ext3_free_branches+0xcb/0x1e0
 [<c0180ceb>] ext3_free_branches+0xcb/0x1e0
 [<c0181206>] ext3_truncate+0x406/0x520
 [<c018899f>] journal_start+0x7f/0xc0
 [<c017e9f5>] start_transaction+0x15/0x60
 [<c017eb59>] ext3_delete_inode+0x99/0xe0
 [<c017eac0>] ext3_delete_inode+0x0/0xe0
 [<c0164d41>] generic_delete_inode+0x61/0x100
 [<c0164f78>] iput+0x58/0x80
 [<c015b89d>] sys_unlink+0xdd/0x120
 [<c015d8c9>] sys_ioctl+0xc9/0x260
 [<c010a8a7>] syscall_call+0x7/0xb

ext3_abort called.
EXT3-fs abort (device hdb5): ext3_journal_start: Detected aborted journal
Remounting filesystem read-only
ext3_reserve_inode_write: aborting transaction: Journal has aborted in __ext3_journal_get_write_access<2>EXT3-fs error (device hdb5) in ext3_reserve_inode_write: Journal has aborted
EXT3-fs error (device hdb5) in ext3_truncate: Journal has aborted
ext3_reserve_inode_write: aborting transaction: Journal has aborted in __ext3_journal_get_write_access<2>EXT3-fs error (device hdb5) in ext3_reserve_inode_write: Journal has aborted
EXT3-fs error (device hdb5) in ext3_orphan_del: Journal has aborted
ext3_reserve_inode_write: aborting transaction: Journal has aborted in __ext3_journal_get_write_access<2>EXT3-fs error (device hdb5) in ext3_reserve_inode_write: Journal has aborted
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
__journal_remove_journal_head: freeing b_committed_data
EXT3-fs error (device hdb5) in ext3_delete_inode: Journal has aborted

[-- Attachment #3: smartctl.txt --]
[-- Type: text/plain, Size: 4014 bytes --]

smartctl version 5.26 Copyright (C) 2002-3 Bruce Allen
Home page is http://smartmontools.sourceforge.net/

=== START OF INFORMATION SECTION ===
Device Model:     QUANTUM FIREBALLlct20 40
Serial Number:    754036117443
Firmware Version: APL.0900
Device is:        Not in smartctl database [for details use: -P showall]
ATA Version is:   5
ATA Standard is:  ATA/ATAPI-5 T13 1321D revision 1
Local Time is:    Sat Feb 21 01:58:11 2004 BRT
SMART support is: Available - device has SMART capability.
SMART support is: Enabled

=== START OF READ SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED

General SMART Values:
Offline data collection status:  (0x05)	Offline data collection activity was
					aborted by an interrupting command from host.
					Auto Offline Data Collection: Disabled.
Self-test execution status:      (  32)	The self-test routine was interrupted
					by the host with a hard or soft reset.
Total time to complete Offline 
data collection: 		 (  51) seconds.
Offline data collection
capabilities: 			 (0x1b) SMART execute Offline immediate.
					Auto Offline data collection on/off support.
					Suspend Offline collection upon new
					command.
					Offline surface scan supported.
					Self-test supported.
					No Conveyance Self-test supported.
					No Selective Self-test supported.
SMART capabilities:            (0x0003)	Saves SMART data before entering
					power-saving mode.
					Supports SMART auto save timer.
Error logging capability:        (0x01)	Error logging supported.
					No General Purpose Logging support.
Short self-test routine 
recommended polling time: 	 (   2) minutes.
Extended self-test routine
recommended polling time: 	 (  47) minutes.

SMART Attributes Data Structure revision number: 11
Vendor Specific SMART Attributes with Thresholds:
ID# ATTRIBUTE_NAME          FLAG     VALUE WORST THRESH TYPE      UPDATED  WHEN_FAILED RAW_VALUE
  1 Raw_Read_Error_Rate     0x0029   100   253   020    Pre-fail  Offline      -       0
  3 Spin_Up_Time            0x0027   078   078   020    Pre-fail  Always       -       2791
  4 Start_Stop_Count        0x0032   097   097   008    Old_age   Always       -       2452
  5 Reallocated_Sector_Ct   0x0033   100   100   020    Pre-fail  Always       -       1
  7 Seek_Error_Rate         0x000b   100   093   023    Pre-fail  Always       -       0
  9 Power_On_Hours          0x0012   087   087   001    Old_age   Always       -       8705
 10 Spin_Retry_Count        0x0026   100   095   000    Old_age   Always       -       0
 11 Calibration_Retry_Count 0x0013   100   100   020    Pre-fail  Always       -       0
 12 Power_Cycle_Count       0x0032   097   097   008    Old_age   Always       -       2365
 13 Read_Soft_Error_Rate    0x000b   100   093   023    Pre-fail  Always       -       0
195 Hardware_ECC_Recovered  0x001a   100   100   000    Old_age   Always       -       31292
196 Reallocated_Event_Count 0x0010   100   100   020    Old_age   Offline      -       0
197 Current_Pending_Sector  0x0032   100   100   020    Old_age   Always       -       0
198 Offline_Uncorrectable   0x0010   100   253   000    Old_age   Offline      -       0
199 UDMA_CRC_Error_Count    0x001a   200   020   000    Old_age   Always       -       4866

SMART Error Log Version: 0
No Errors Logged

SMART Self-test log structure revision number 0
Warning: ATA Specification requires self-test log structure revision number = 1
Num  Test_Description    Status                  Remaining  LifeTime(hours)  LBA_of_first_error
# 1  Extended offline    Interrupted (host reset)      10%      8704         -
# 2  Short offline       Completed without error       00%      8681         -
# 3  Short offline       Completed without error       00%      8657         -
# 4  Short offline       Completed without error       00%      8633         -
# 5  Short offline       Completed without error       00%      8609         -
# 6  Extended offline    Completed without error       00%      8587         -

bad: scheduling while atomic!

[Russell King]

I'm seeing tonnes of this with UP preempt in 2.5.71.  The following is
just one case which I've been able to track down:

bad: scheduling while atomic! (00000250 0 8 mtdblockd)
[<c02372d0>] (schedule+0x0/0x490) from [<c0335fd0>] (mtd_blktrans_thread+0x220/0x258)
 r7 = 00000000  r6 = C0109FBC  r5 = C0108000  r4 = C0109FB8
[<c0335db0>] (mtd_blktrans_thread+0x0/0x258) from [<c0224554>] (kernel_thread+0x40/0x48)
bad: scheduling while atomic! (00000251 0 8 mtdblockd)
[<c02372d0>] (schedule+0x0/0x490) from [<c0335fd0>] (mtd_blktrans_thread+0x220/0x258)
 r7 = 00000000  r6 = C0109FBC  r5 = C0108000  r4 = C0109FB8
[<c0335db0>] (mtd_blktrans_thread+0x0/0x258) from [<c0224554>] (kernel_thread+0x40/0x48)
bad: scheduling while atomic! (00000252 0 8 mtdblockd)
[<c02372d0>] (schedule+0x0/0x490) from [<c0335fd0>] (mtd_blktrans_thread+0x220/0x258)
 r7 = 00000000  r6 = C0109FBC  r5 = C0108000  r4 = C0109FB8
[<c0335db0>] (mtd_blktrans_thread+0x0/0x258) from [<c0224554>] (kernel_thread+0x40/0x48)

(The extra numbers are: preempt_count, kernel_locked, pid and comm).

This instance seems to be caused by the following code in
drivers/mtd/mtd_blkdevs.c:

         while (!tr->blkcore_priv->exiting) {
                 spin_lock_irq(rq->queue_lock);
 ...
                 spin_unlock_irq(rq->queue_lock);
 ...
                 spin_lock_irq(rq->queue_lock);
 ...
         }

It would be useful if we could balance the spin_locks with the
spin_unlocks. 8)

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: bad: scheduling while atomic!

[Jörn Engel]

On Sun, 15 June 2003 14:29:50 +0100, Russell King wrote:
> 
> This instance seems to be caused by the following code in
> drivers/mtd/mtd_blkdevs.c:
> 
>          while (!tr->blkcore_priv->exiting) {
>                  spin_lock_irq(rq->queue_lock);
>  ...
>                  spin_unlock_irq(rq->queue_lock);
>  ...
>                  spin_lock_irq(rq->queue_lock);
>  ...
>          }
> 
> It would be useful if we could balance the spin_locks with the
> spin_unlocks. 8)

How about this mindless guess?

Jörn

-- 
It's just what we asked for, but not what we want!
-- anonymous

--- linux-2.5.71/drivers/mtd/mtd_blkdevs.c~mtd_spinlocks	2003-06-15 16:05:05.000000000 +0200
+++ linux-2.5.71/drivers/mtd/mtd_blkdevs.c	2003-06-15 16:19:43.000000000 +0200
@@ -93,14 +93,13 @@
 	recalc_sigpending();
 	spin_unlock_irq(&current->sighand->siglock);
 
+	spin_lock_irq(rq->queue_lock);
 	while (!tr->blkcore_priv->exiting) {
 		struct request *req;
 		struct mtd_blktrans_dev *dev;
 		int res = 0;
 		DECLARE_WAITQUEUE(wait, current);
 
-		spin_lock_irq(rq->queue_lock);
-
 		req = elv_next_request(rq);
 
 		if (!req) {
@@ -112,6 +111,7 @@
 			schedule();
 			remove_wait_queue(&tr->blkcore_priv->thread_wq, &wait);
 
+			spin_lock_irq(rq->queue_lock);
 			continue;
 		}
 

Re: bad: scheduling while atomic!

[David Woodhouse]

On Sun, 2003-06-15 at 14:29, Russell King wrote:
> It would be useful if we could balance the spin_locks with the
> spin_unlocks. 8)

I can see how that could be considered appropriate. There are a handful
of other such trivia in CVS which want to go to Linus shortly -- I
assume that includes your afs partitioning fix?

-- 
dwmw2

Re: bad: scheduling while atomic!

[Russell King]

On Sun, Jun 15, 2003 at 06:14:38PM +0100, David Woodhouse wrote:
> On Sun, 2003-06-15 at 14:29, Russell King wrote:
> > It would be useful if we could balance the spin_locks with the
> > spin_unlocks. 8)
> 
> I can see how that could be considered appropriate. There are a handful
> of other such trivia in CVS which want to go to Linus shortly -- I
> assume that includes your afs partitioning fix?

Yes, although I was considering sending that one myself.  If you're due
to do another sync up, feel free to include that.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: bad: scheduling while atomic!

[David Woodhouse]

On Sun, 2003-06-15 at 18:17, Russell King wrote:
> Yes, although I was considering sending that one myself.  If you're due
> to do another sync up, feel free to include that.

Well, given the 'NFTL aborts if add_mtd_blktrans functions exists,
rather calling it and aborting only it it returns non-zero' bug, I
suppose I am due such ;)

-- 
dwmw2