All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, discuss@x86-64.org,
	linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	linux-sh@m17n.org, linux-390@vm.marist.edu,
	sparclinux@vger.kernel.org, linuxppc64-dev@ozlabs.org,
	linux-arm-kernel@lists.arm.linux.org.uk,
	parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] [PATCH] Add key management syscalls to non-i386 archs
Date: Wed, 20 Oct 2004 15:49:22 +0000	[thread overview]
Message-ID: <20041020154922.GV16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3506.1098283455@redhat.com>

On Wed, Oct 20, 2004 at 03:44:15PM +0100, David Howells wrote:
> The attached patch adds syscalls for almost all archs (everything barring
> m68knommu which is in a real mess, and i386 which already has it).
> 
> It also adds 32->64 compatibility where appropriate.

> --- linux-2.6.9-bk4/arch/parisc/kernel/syscall_table.S	2004-06-18 13:43:47.000000000 +0100
> +++ linux-2.6.9-bk4-keys/arch/parisc/kernel/syscall_table.S	2004-10-20 14:58:51.533643420 +0100
> @@ -341,5 +341,7 @@
>    ENTRY_SAME(mq_timedreceive)
>    ENTRY_SAME(mq_notify)
>    ENTRY_SAME(mq_getsetattr)
> -  /* Nothing yet */       /* 235 */
> +	ENTRY_SAME(add_key)	/* 235 */
> +	ENTRY_SAME(request_key)
> +	ENTRY_SAME(keyctl)

Um, no.  Should be ENTRY_COMP() if there's compat syscalls.  And those
particular syscall numbers have already been assigned (blame Linus for
dropping the PA-RISC patch on the floor instead of including it in 2.6.9).

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, discuss@x86-64.org,
	linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	linux-sh@m17n.org, linux-390@vm.marist.edu,
	sparclinux@vger.kernel.org, linuxppc64-dev@ozlabs.org,
	linux-arm-kernel@lists.arm.linux.org.uk,
	parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] [PATCH] Add key management syscalls to non-i386 archs
Date: Wed, 20 Oct 2004 16:49:22 +0100	[thread overview]
Message-ID: <20041020154922.GV16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3506.1098283455@redhat.com>

On Wed, Oct 20, 2004 at 03:44:15PM +0100, David Howells wrote:
> The attached patch adds syscalls for almost all archs (everything barring
> m68knommu which is in a real mess, and i386 which already has it).
> 
> It also adds 32->64 compatibility where appropriate.

> --- linux-2.6.9-bk4/arch/parisc/kernel/syscall_table.S	2004-06-18 13:43:47.000000000 +0100
> +++ linux-2.6.9-bk4-keys/arch/parisc/kernel/syscall_table.S	2004-10-20 14:58:51.533643420 +0100
> @@ -341,5 +341,7 @@
>    ENTRY_SAME(mq_timedreceive)
>    ENTRY_SAME(mq_notify)
>    ENTRY_SAME(mq_getsetattr)
> -  /* Nothing yet */       /* 235 */
> +	ENTRY_SAME(add_key)	/* 235 */
> +	ENTRY_SAME(request_key)
> +	ENTRY_SAME(keyctl)

Um, no.  Should be ENTRY_COMP() if there's compat syscalls.  And those
particular syscall numbers have already been assigned (blame Linus for
dropping the PA-RISC patch on the floor instead of including it in 2.6.9).

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  parent reply	other threads:[~2004-10-20 15:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20 14:44 [PATCH] Add key management syscalls to non-i386 archs David Howells
2004-10-20 14:44 ` David Howells
2004-10-20 15:29 ` Christoph Hellwig
2004-10-20 15:29   ` Christoph Hellwig
2004-10-20 17:50   ` Andrew Morton
2004-10-20 17:50     ` Andrew Morton
2004-10-20 18:18     ` Christoph Hellwig
2004-10-20 18:18       ` Christoph Hellwig
2004-10-20 15:49 ` Matthew Wilcox [this message]
2004-10-20 15:49   ` [parisc-linux] " Matthew Wilcox
2004-10-20 16:16   ` David Howells
2004-10-20 16:16     ` David Howells
2004-10-20 16:42 ` Geert Uytterhoeven
2004-10-21  3:14   ` [uClinux-dev] " Greg Ungerer
2004-10-20 17:08 ` Arnd Bergmann
2004-10-20 17:08   ` Arnd Bergmann
2004-10-20 22:01 ` David S. Miller
2004-10-20 22:01   ` David S. Miller
2004-10-20 22:56   ` [discuss] " Andi Kleen
2004-10-20 22:56     ` Andi Kleen
2004-10-20 23:04     ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 David S. Miller
2004-10-20 23:04       ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs David S. Miller
2004-10-20 23:25       ` Andi Kleen
2004-10-20 23:25         ` Andi Kleen
2004-10-20 23:41         ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 David S. Miller
2004-10-20 23:41           ` David S. Miller
2004-10-20 23:41           ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs David S. Miller
2004-10-20 23:41           ` David S. Miller
2004-10-21  0:10           ` Andi Kleen
2004-10-21  0:10             ` Andi Kleen
2004-10-21  8:03           ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 Geert Uytterhoeven
2004-10-21  8:03             ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Geert Uytterhoeven
2004-10-21  1:55       ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 Benjamin Herrenschmidt
2004-10-21  1:55         ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Benjamin Herrenschmidt
2004-10-21  8:47       ` Jan-Benedict Glaw
2004-10-21  8:47         ` Jan-Benedict Glaw
  -- strict thread matches above, loose matches on Subject: below --
2004-10-20 14:44 [parisc-linux] " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041020154922.GV16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=discuss@x86-64.org \
    --cc=linux-390@vm.marist.edu \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-sh@m17n.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=parisc-linux@parisc-linux.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.