All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: David Howells <dhowells@redhat.com>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
	discuss@x86-64.org, sparclinux@vger.kernel.org,
	linuxppc64-dev@ozlabs.org, linux-m68k@vger.kernel.org,
	linux-sh@m17n.org, linux-arm-kernel@lists.arm.linux.org.uk,
	parisc-linux@parisc-linux.org, linux-ia64@vger.kernel.org,
	linux-390@vm.marist.edu, linux-mips@linux-mips.org
Subject: Re: [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs
Date: Wed, 20 Oct 2004 22:56:25 +0000	[thread overview]
Message-ID: <20041020225625.GD995@wotan.suse.de> (raw)
In-Reply-To: <20041020150149.7be06d6d.davem@davemloft.net>

On Wed, Oct 20, 2004 at 03:01:49PM -0700, David S. Miller wrote:
> 
> David, I applaud your effort to take care of this.
> However, this patch will conflict with what I've
> sent into Linus already for Sparc.  I also had to
> add the sys_altroot syscall entry as well.
> 
> I've mentioned several times that perhaps the best
> way to deal with this problem is to purposefully
> break the build of platforms when new system calls
> are added.
> 
> Simply adding a:
> 
> #error new syscall entries for X and Y needed
> 
> to include/asm-*/unistd.h would handle this just
> fine I think.

I don't think that's a good idea.  Normally new system calls 
are relatively obscure and the system works fine without them,
so urgent action is not needed.

And I think we can trust architecture maintainers to regularly
sync the system calls with i386.

-Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: David Howells <dhowells@redhat.com>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
	discuss@x86-64.org, sparclinux@vger.kernel.org,
	linuxppc64-dev@ozlabs.org, linux-m68k@vger.kernel.org,
	linux-sh@m17n.org, linux-arm-kernel@lists.arm.linux.org.uk,
	parisc-linux@parisc-linux.org, linux-ia64@vger.kernel.org,
	linux-390@vm.marist.edu, linux-mips@linux-mips.org
Subject: Re: [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs
Date: Thu, 21 Oct 2004 00:56:25 +0200	[thread overview]
Message-ID: <20041020225625.GD995@wotan.suse.de> (raw)
In-Reply-To: <20041020150149.7be06d6d.davem@davemloft.net>

On Wed, Oct 20, 2004 at 03:01:49PM -0700, David S. Miller wrote:
> 
> David, I applaud your effort to take care of this.
> However, this patch will conflict with what I've
> sent into Linus already for Sparc.  I also had to
> add the sys_altroot syscall entry as well.
> 
> I've mentioned several times that perhaps the best
> way to deal with this problem is to purposefully
> break the build of platforms when new system calls
> are added.
> 
> Simply adding a:
> 
> #error new syscall entries for X and Y needed
> 
> to include/asm-*/unistd.h would handle this just
> fine I think.

I don't think that's a good idea.  Normally new system calls 
are relatively obscure and the system works fine without them,
so urgent action is not needed.

And I think we can trust architecture maintainers to regularly
sync the system calls with i386.

-Andi

  reply	other threads:[~2004-10-20 22:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20 14:44 [PATCH] Add key management syscalls to non-i386 archs David Howells
2004-10-20 14:44 ` David Howells
2004-10-20 15:29 ` Christoph Hellwig
2004-10-20 15:29   ` Christoph Hellwig
2004-10-20 17:50   ` Andrew Morton
2004-10-20 17:50     ` Andrew Morton
2004-10-20 18:18     ` Christoph Hellwig
2004-10-20 18:18       ` Christoph Hellwig
2004-10-20 15:49 ` [parisc-linux] " Matthew Wilcox
2004-10-20 15:49   ` Matthew Wilcox
2004-10-20 16:16   ` David Howells
2004-10-20 16:16     ` David Howells
2004-10-20 16:42 ` Geert Uytterhoeven
2004-10-21  3:14   ` [uClinux-dev] " Greg Ungerer
2004-10-20 17:08 ` Arnd Bergmann
2004-10-20 17:08   ` Arnd Bergmann
2004-10-20 22:01 ` David S. Miller
2004-10-20 22:01   ` David S. Miller
2004-10-20 22:56   ` Andi Kleen [this message]
2004-10-20 22:56     ` [discuss] " Andi Kleen
2004-10-20 23:04     ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 David S. Miller
2004-10-20 23:04       ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs David S. Miller
2004-10-20 23:25       ` Andi Kleen
2004-10-20 23:25         ` Andi Kleen
2004-10-20 23:41         ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 David S. Miller
2004-10-20 23:41           ` David S. Miller
2004-10-20 23:41           ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs David S. Miller
2004-10-20 23:41           ` David S. Miller
2004-10-21  0:10           ` Andi Kleen
2004-10-21  0:10             ` Andi Kleen
2004-10-21  8:03           ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 Geert Uytterhoeven
2004-10-21  8:03             ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Geert Uytterhoeven
2004-10-21  1:55       ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 Benjamin Herrenschmidt
2004-10-21  1:55         ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Benjamin Herrenschmidt
2004-10-21  8:47       ` Jan-Benedict Glaw
2004-10-21  8:47         ` Jan-Benedict Glaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041020225625.GD995@wotan.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=discuss@x86-64.org \
    --cc=linux-390@vm.marist.edu \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-sh@m17n.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=parisc-linux@parisc-linux.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.