Re: [RFC] h323 module unloading fix

[Max Kellermann <max@duempel.org>]

On 2005/02/08 15:59, Harald Welte <laforge@netfilter.org> wrote:
[...]
> This is because the h245 helper is not registered with the core, and
> therefore the helper_unregister() function will only be called for h245,
> but not for h245.
> 
> The proposed solution:
> 
> 1) to make ip_conntrack_core:ip_conntrack_helper_unregister() work with
>    a helper that was never registered (and thus has an empty list.next)
> 2) to have ip_conntrack_h323 unregister the h245 helper.

I think your patch regarding ip_conntrack_core.c is a workaround, that
does not look clean to me. I prefer to make H.323 register the H.245
helper with a disabled mask (only to be activated internally by
H.225), and then unregister it cleanly.

I guess your proposition (1) would make another workaround.

Max