All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Kellermann <max@duempel.org>
To: Harald Welte <laforge@netfilter.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [RFC] h323 module unloading fix
Date: Tue, 8 Feb 2005 16:55:27 +0100	[thread overview]
Message-ID: <20050208155527.GA31418@roonstrasse.net> (raw)
In-Reply-To: <20050208155238.GT6878@sunbeam.de.gnumonks.org>

On 2005/02/08 16:52, Harald Welte <laforge@netfilter.org> wrote:
> Yes, but every additional entry in the list of helpers is matched
> against every packet...  and I don't want to waste performance just for
> being a bit more clean.
> 
> But maybe we could add a flag to the helper like F_DISABLED which would
> disable matching for that particular helper.

That flag could be determined automatically in the register function
by looking at the mask.

Then the helper could be inserted into another list, which is only
used in the unregister function for cleanup. This way, the netfilter
core does not even have to traverse these helpers in the list to check
the "disabled" flag.

Max

  reply	other threads:[~2005-02-08 15:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-08 14:59 [RFC] h323 module unloading fix Harald Welte
2005-02-08 15:26 ` Max Kellermann
2005-02-08 15:52   ` Harald Welte
2005-02-08 15:55     ` Max Kellermann [this message]
2005-02-08 23:10 ` Patrick McHardy
2005-02-09  8:24   ` Harald Welte
2005-02-09  8:59     ` Jozsef Kadlecsik
2005-02-09  9:10       ` Max Kellermann
2005-02-09 10:25         ` Jozsef Kadlecsik
2005-02-09 10:05       ` Harald Welte
2005-02-09 13:34     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050208155527.GA31418@roonstrasse.net \
    --to=max@duempel.org \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.