From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [RFC] h323 module unloading fix
Date: Wed, 09 Feb 2005 14:34:54 +0100 [thread overview]
Message-ID: <420A117E.8080706@trash.net> (raw)
In-Reply-To: <20050209082459.GY6878@sunbeam.de.gnumonks.org>
Harald Welte wrote:
>On Wed, Feb 09, 2005 at 12:10:55AM +0100, Patrick McHardy wrote:
>
>>But I think splitting the code to evict expectations and expected
>>conntracks from ip_conntrack_helper_unregister is a cleaner solution.
>>
>
>Mh, but then every author of a helper would explicitly have to take care
>of calling the 'evicting function'. Considering that any existing
>helper, tutorial and other documentation tells him that he doesn't have
>to, it's easy to get it wrong and introduce further bugs.
>
I meant you should still call it from ip_conntrack_helper_unregister,
but also from the h323 helper. Of course its mostly cosmetic, a comment
before calling unregister is probably just as good.
Regards
Patrick
prev parent reply other threads:[~2005-02-09 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 14:59 [RFC] h323 module unloading fix Harald Welte
2005-02-08 15:26 ` Max Kellermann
2005-02-08 15:52 ` Harald Welte
2005-02-08 15:55 ` Max Kellermann
2005-02-08 23:10 ` Patrick McHardy
2005-02-09 8:24 ` Harald Welte
2005-02-09 8:59 ` Jozsef Kadlecsik
2005-02-09 9:10 ` Max Kellermann
2005-02-09 10:25 ` Jozsef Kadlecsik
2005-02-09 10:05 ` Harald Welte
2005-02-09 13:34 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420A117E.8080706@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.