Re: [RFC] h323 module unloading fix

[Max Kellermann <max@duempel.org>]

On 2005/02/09 09:59, Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> wrote:
> I like Patrick's idea. There are not so many modules wich rely on
> unregistered helpers, and we could retain backward compatibility in the
> API like in the attached (untested) patch. What do you think?

Calling an "evicting" function in a module destructor for something
which the netfilter core didn't even know about until now doesn't look
elegant to me. For me, to every destructing function, there must be a
prior constructor call.

There is no compatibility problem with Harald's/my solution. My
proposition allows the "register_helper" function to register
"disabled" helpers, meaning that you have to both register and
unregister the H.245 helper.

If we ever decide that it is required to register "disabled" helpers,
we don't have to change the API again, and it costs us near to nothing
to instruct that now.

It does not matter if "register_helper" ignores disabled helpers for
now, and "unregister_helper" works like the "evicting" function
Patrick proposed; we can change internals like this any time we want
without having to touch modules again.

Max