Re: [RFC] h323 module unloading fix

[Patrick McHardy <kaber@trash.net>]

Harald Welte wrote:

>Hi!
>
>If you unload the ip_conntrack_h323 module while a h323 session is in
>progress, the conntrack table is left with corrupted entries (->helper
>pointer still pointing to a now no longer existing h245 helper).
>
>This is because the h245 helper is not registered with the core, and
>therefore the helper_unregister() function will only be called for h245,
>but not for h245.
>
>The proposed solution:
>
>1) to make ip_conntrack_core:ip_conntrack_helper_unregister() work with
>   a helper that was never registered (and thus has an empty list.next)
>2) to have ip_conntrack_h323 unregister the h245 helper.
>
>Any comments?
>
You can initialize helper->list and replace LIST_DELETE by list_del, 
then you
can avoid the check for list.next. But I think splitting the code to evict
expectations and expected conntracks from ip_conntrack_helper_unregister is
a cleaner solution.

Regards
Patrick