All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c
@ 2006-05-15 12:18 Christophe Lucas
  2006-05-15 12:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-15 12:18 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h2.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c	2006-05-15 12:24:39.000000000 +0200
@@ -121,7 +121,7 @@
 static void __init h2_init_smc91x(void)
 {
 	if ((omap_request_gpio(0)) < 0) {
-		printk("Error requesting gpio 0 for smc91x irq\n");
+		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");
 		return;
 	}
 }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
@ 2006-05-15 12:19 ` Christophe Lucas
  2006-05-15 12:20 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Christophe Lucas
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-15 12:19 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h3.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c	2006-05-15 12:25:21.000000000 +0200
@@ -196,7 +196,7 @@
 {
 	omap_cfg_reg(W15_1710_GPIO40);
 	if (omap_request_gpio(40) < 0) {
-		printk("Error requesting gpio 40 for smc91x irq\n");
+		printk(KERN_WARNING "Error requesting gpio 40 for smc91x irq\n");
 		return;
 	}
 }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
  2006-05-15 12:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
@ 2006-05-15 12:20 ` Christophe Lucas
  2006-05-15 14:34 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-15 12:20 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


Index: linux-2.6.16.16/arch/arm/mach-omap1/board-innovator.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-innovator.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-innovator.c	2006-05-15 12:26:20.000000000 +0200
@@ -173,7 +173,7 @@
 		udelay(750);
 	} else {
 		if ((omap_request_gpio(0)) < 0) {
-			printk("Error requesting gpio 0 for smc91x irq\n");
+			printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");
 			return;
 		}
 	}
@@ -294,7 +294,7 @@
 		udelay(10);	/* Delay needed for FPGA */
 
 		/* Dump the Innovator FPGA rev early - useful info for support. */
-		printk("Innovator FPGA Rev %d.%d Board Rev %d\n",
+		printk(KERN_INFO "Innovator FPGA Rev %d.%d Board Rev %d\n",
 		       fpga_read(OMAP1510_FPGA_REV_HIGH),
 		       fpga_read(OMAP1510_FPGA_REV_LOW),
 		       fpga_read(OMAP1510_FPGA_BOARD_REV));

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
  2006-05-15 12:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
  2006-05-15 12:20 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Christophe Lucas
@ 2006-05-15 14:34 ` Christophe Lucas
  2006-05-18  8:08 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Arthur Othieno
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-15 14:34 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c	2006-05-15 12:27:32.000000000 +0200
@@ -148,7 +148,7 @@
 static void __init osk_init_smc91x(void)
 {
 	if ((omap_request_gpio(0)) < 0) {
-		printk("Error requesting gpio 0 for smc91x irq\n");
+		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");
 		return;
 	}
 
@@ -160,7 +160,7 @@
 {
 	omap_cfg_reg(M7_1610_GPIO62);
 	if ((omap_request_gpio(62)) < 0) {
-		printk("Error requesting gpio 62 for CF irq\n");
+		printk(KERN_WARNING "Error requesting gpio 62 for CF irq\n");
 		return;
 	}
 	/* the CF I/O IRQ is really active-low */

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (2 preceding siblings ...)
  2006-05-15 14:34 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
@ 2006-05-18  8:08 ` Arthur Othieno
  2006-05-18  8:10 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Arthur Othieno
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Arthur Othieno @ 2006-05-18  8:08 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On Mon, May 15, 2006 at 02:18:24PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c
> ===================================================================
> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h2.c	2006-05-11 03:56:24.000000000 +0200
> +++ linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c	2006-05-15 12:24:39.000000000 +0200
> @@ -121,7 +121,7 @@
>  static void __init h2_init_smc91x(void)
>  {
>  	if ((omap_request_gpio(0)) < 0) {
> -		printk("Error requesting gpio 0 for smc91x irq\n");
> +		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");

On error path. KERN_ERR here.

>  		return;
>  	}
>  }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (3 preceding siblings ...)
  2006-05-18  8:08 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Arthur Othieno
@ 2006-05-18  8:10 ` Arthur Othieno
  2006-05-18  8:15 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Arthur Othieno
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Arthur Othieno @ 2006-05-18  8:10 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Mon, May 15, 2006 at 02:19:09PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c
> ===================================================================
> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h3.c	2006-05-11 03:56:24.000000000 +0200
> +++ linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c	2006-05-15 12:25:21.000000000 +0200
> @@ -196,7 +196,7 @@
>  {
>  	omap_cfg_reg(W15_1710_GPIO40);
>  	if (omap_request_gpio(40) < 0) {
> -		printk("Error requesting gpio 40 for smc91x irq\n");
> +		printk(KERN_WARNING "Error requesting gpio 40 for smc91x irq\n");

Ditto KERN_ERR.

>  		return;
>  	}
>  }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (4 preceding siblings ...)
  2006-05-18  8:10 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Arthur Othieno
@ 2006-05-18  8:15 ` Arthur Othieno
  2006-05-18  8:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Arthur Othieno
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Arthur Othieno @ 2006-05-18  8:15 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Mon, May 15, 2006 at 04:34:45PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> 
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c
> ===================================================================
> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c	2006-05-11 03:56:24.000000000 +0200
> +++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c	2006-05-15 12:27:32.000000000 +0200
> @@ -148,7 +148,7 @@
>  static void __init osk_init_smc91x(void)
>  {
>  	if ((omap_request_gpio(0)) < 0) {
> -		printk("Error requesting gpio 0 for smc91x irq\n");
> +		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");

KERN_ERR

>  		return;
>  	}
>  
> @@ -160,7 +160,7 @@
>  {
>  	omap_cfg_reg(M7_1610_GPIO62);
>  	if ((omap_request_gpio(62)) < 0) {
> -		printk("Error requesting gpio 62 for CF irq\n");
> +		printk(KERN_WARNING "Error requesting gpio 62 for CF irq\n");

Ditto.

>  		return;
>  	}
>  	/* the CF I/O IRQ is really active-low */

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (5 preceding siblings ...)
  2006-05-18  8:15 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Arthur Othieno
@ 2006-05-18  8:19 ` Arthur Othieno
  2006-05-18  8:25 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Arthur Othieno @ 2006-05-18  8:19 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

On Mon, May 15, 2006 at 02:20:16PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> 
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-innovator.c
> ===================================================================
> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-innovator.c	2006-05-11 03:56:24.000000000 +0200
> +++ linux-2.6.16.16/arch/arm/mach-omap1/board-innovator.c	2006-05-15 12:26:20.000000000 +0200
> @@ -173,7 +173,7 @@
>  		udelay(750);
>  	} else {
>  		if ((omap_request_gpio(0)) < 0) {
> -			printk("Error requesting gpio 0 for smc91x irq\n");
> +			printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");

Ditto KERN_ERR.

>  			return;
>  		}
>  	}

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (6 preceding siblings ...)
  2006-05-18  8:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Arthur Othieno
@ 2006-05-18  8:25 ` Christophe Lucas
  2006-05-18  8:30 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-18  8:25 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

Arthur Othieno (apgo@patchbomb.org) wrote:
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c
> > ===================================================================
> > --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h3.c	2006-05-11 03:56:24.000000000 +0200
> > +++ linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c	2006-05-15 12:25:21.000000000 +0200
> 
> Ditto KERN_ERR.

Ok Here is the corriged patch:

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h3.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c	2006-05-18 10:23:33.000000000 +0200
@@ -196,7 +196,7 @@
 {
 	omap_cfg_reg(W15_1710_GPIO40);
 	if (omap_request_gpio(40) < 0) {
-		printk("Error requesting gpio 40 for smc91x irq\n");
+		printk(KERN_ERR "Error requesting gpio 40 for smc91x irq\n");
 		return;
 	}
 }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (7 preceding siblings ...)
  2006-05-18  8:25 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
@ 2006-05-18  8:30 ` Christophe Lucas
  2006-05-18  8:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-18  8:30 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]

Arthur Othieno (apgo@patchbomb.org) wrote:
> On Mon, May 15, 2006 at 02:18:24PM +0200, Christophe Lucas wrote:
> > Description:
> > printk should include appropriate KERN_* constant (of course
> > only at beginning of lines).
> > 
> > Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> > 
> > Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c
> > ===================================================================
> > --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h2.c	2006-05-11 03:56:24.000000000 +0200
> > +++ linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c	2006-05-15 12:24:39.000000000 +0200
> > @@ -121,7 +121,7 @@
> >  static void __init h2_init_smc91x(void)
> >  {
> >  	if ((omap_request_gpio(0)) < 0) {
> > -		printk("Error requesting gpio 0 for smc91x irq\n");
> > +		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");
> 
> On error path. KERN_ERR here.
> 
> >  		return;
> >  	}
> >  }

Ok here it is the corriged patch :

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h2.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-h2.c	2006-05-18 10:26:14.000000000 +0200
@@ -121,7 +121,7 @@
 static void __init h2_init_smc91x(void)
 {
 	if ((omap_request_gpio(0)) < 0) {
-		printk("Error requesting gpio 0 for smc91x irq\n");
+		printk(KERN_ERR "Error requesting gpio 0 for smc91x irq\n");
 		return;
 	}
 }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (8 preceding siblings ...)
  2006-05-18  8:30 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
@ 2006-05-18  8:35 ` Christophe Lucas
  2006-05-26 10:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/id.c Christophe Lucas
  2006-05-26 11:51 ` Alexey Dobriyan
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-18  8:35 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]

Arthur Othieno (apgo@patchbomb.org) wrote:
> On Mon, May 15, 2006 at 04:34:45PM +0200, Christophe Lucas wrote:
> > Description:
> > printk should include appropriate KERN_* constant (of course
> > only at beginning of lines).
> > 
> > Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> > 
> > 
> > Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c
> > ===================================================================
> > --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c	2006-05-11 03:56:24.000000000 +0200
> > +++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c	2006-05-15 12:27:32.000000000 +0200
> > @@ -148,7 +148,7 @@
> >  static void __init osk_init_smc91x(void)
> >  {
> >  	if ((omap_request_gpio(0)) < 0) {
> > -		printk("Error requesting gpio 0 for smc91x irq\n");
> > +		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");
> 
> KERN_ERR
> 
> >  		return;
> >  	}
> >  
> > @@ -160,7 +160,7 @@
> >  {
> >  	omap_cfg_reg(M7_1610_GPIO62);
> >  	if ((omap_request_gpio(62)) < 0) {
> > -		printk("Error requesting gpio 62 for CF irq\n");
> > +		printk(KERN_WARNING "Error requesting gpio 62 for CF irq\n");
> 
> Ditto.
> 
> >  		return;
> >  	}
> >  	/* the CF I/O IRQ is really active-low */

Here it is the corriged version :

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>



Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c
===================================================================
--- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c	2006-05-18 10:22:59.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c	2006-05-18 10:33:55.000000000 +0200
@@ -148,7 +148,7 @@
 static void __init osk_init_smc91x(void)
 {
 	if ((omap_request_gpio(0)) < 0) {
-		printk("Error requesting gpio 0 for smc91x irq\n");
+		printk(KERN_ERR "Error requesting gpio 0 for smc91x irq\n");
 		return;
 	}
 
@@ -160,7 +160,7 @@
 {
 	omap_cfg_reg(M7_1610_GPIO62);
 	if ((omap_request_gpio(62)) < 0) {
-		printk("Error requesting gpio 62 for CF irq\n");
+		printk(KERN_ERR "Error requesting gpio 62 for CF irq\n");
 		return;
 	}
 	/* the CF I/O IRQ is really active-low */

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [KJ] [PATCH] printk : arch/arm/mach-omap1/id.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (9 preceding siblings ...)
  2006-05-18  8:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
@ 2006-05-26 10:35 ` Christophe Lucas
  2006-05-26 11:51 ` Alexey Dobriyan
  11 siblings, 0 replies; 13+ messages in thread
From: Christophe Lucas @ 2006-05-26 10:35 UTC (permalink / raw)
  To: kernel-janitors

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


Index: linux-2.6.16.16/arch/arm/mach-omap1/id.c
=================================--- linux-2.6.16.16.orig/arch/arm/mach-omap1/id.c	2006-05-11 03:56:24.000000000 +0200
+++ linux-2.6.16.16/arch/arm/mach-omap1/id.c	2006-05-24 17:35:22.000000000 +0200
@@ -123,17 +123,17 @@
 	omap_id = omap_readl(OMAP32_ID_0);
 
 #ifdef DEBUG
-	printk("OMAP_DIE_ID_0: 0x%08x\n", omap_readl(OMAP_DIE_ID_0));
-	printk("OMAP_DIE_ID_1: 0x%08x DIE_REV: %i\n",
+	printk(KERN_DEBUG "OMAP_DIE_ID_0: 0x%08x\n", omap_readl(OMAP_DIE_ID_0));
+	printk(KERN_DEBUG "OMAP_DIE_ID_1: 0x%08x DIE_REV: %i\n",
 		omap_readl(OMAP_DIE_ID_1),
 	       (omap_readl(OMAP_DIE_ID_1) >> 17) & 0xf);
-	printk("OMAP_PRODUCTION_ID_0: 0x%08x\n", omap_readl(OMAP_PRODUCTION_ID_0));
-	printk("OMAP_PRODUCTION_ID_1: 0x%08x JTAG_ID: 0x%04x\n",
+	printk(KERN_DEBUG "OMAP_PRODUCTION_ID_0: 0x%08x\n", omap_readl(OMAP_PRODUCTION_ID_0));
+	printk(KERN_DEBUG "OMAP_PRODUCTION_ID_1: 0x%08x JTAG_ID: 0x%04x\n",
 		omap_readl(OMAP_PRODUCTION_ID_1),
 		omap_readl(OMAP_PRODUCTION_ID_1) & 0xffff);
-	printk("OMAP32_ID_0: 0x%08x\n", omap_readl(OMAP32_ID_0));
-	printk("OMAP32_ID_1: 0x%08x\n", omap_readl(OMAP32_ID_1));
-	printk("JTAG_ID: 0x%04x DIE_REV: %i\n", jtag_id, die_rev);
+	printk(KERN_DEBUG "OMAP32_ID_0: 0x%08x\n", omap_readl(OMAP32_ID_0));
+	printk(KERN_DEBUG "OMAP32_ID_1: 0x%08x\n", omap_readl(OMAP32_ID_1));
+	printk(KERN_DEBUG "JTAG_ID: 0x%04x DIE_REV: %i\n", jtag_id, die_rev);
 #endif
 
 	system_serial_high = omap_readl(OMAP_DIE_ID_0);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/id.c
  2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
                   ` (10 preceding siblings ...)
  2006-05-26 10:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/id.c Christophe Lucas
@ 2006-05-26 11:51 ` Alexey Dobriyan
  11 siblings, 0 replies; 13+ messages in thread
From: Alexey Dobriyan @ 2006-05-26 11:51 UTC (permalink / raw)
  To: kernel-janitors

On Fri, May 26, 2006 at 12:35:17PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).

> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/id.c
> +++ linux-2.6.16.16/arch/arm/mach-omap1/id.c
> @@ -123,17 +123,17 @@
>  	omap_id = omap_readl(OMAP32_ID_0);
>  
>  #ifdef DEBUG
> -	printk("OMAP_DIE_ID_0: 0x%08x\n", omap_readl(OMAP_DIE_ID_0));
> -	printk("OMAP_DIE_ID_1: 0x%08x DIE_REV: %i\n",
> +	printk(KERN_DEBUG "OMAP_DIE_ID_0: 0x%08x\n", omap_readl(OMAP_DIE_ID_0));

That would be pr_debug(), no? And you can drop #ifdef too.

> +	printk(KERN_DEBUG "OMAP_DIE_ID_1: 0x%08x DIE_REV: %i\n",
>  		omap_readl(OMAP_DIE_ID_1),
>  	       (omap_readl(OMAP_DIE_ID_1) >> 17) & 0xf);
> -	printk("OMAP_PRODUCTION_ID_0: 0x%08x\n", omap_readl(OMAP_PRODUCTION_ID_0));
> -	printk("OMAP_PRODUCTION_ID_1: 0x%08x JTAG_ID: 0x%04x\n",
> +	printk(KERN_DEBUG "OMAP_PRODUCTION_ID_0: 0x%08x\n", omap_readl(OMAP_PRODUCTION_ID_0));
> +	printk(KERN_DEBUG "OMAP_PRODUCTION_ID_1: 0x%08x JTAG_ID: 0x%04x\n",
>  		omap_readl(OMAP_PRODUCTION_ID_1),
>  		omap_readl(OMAP_PRODUCTION_ID_1) & 0xffff);
> -	printk("OMAP32_ID_0: 0x%08x\n", omap_readl(OMAP32_ID_0));
> -	printk("OMAP32_ID_1: 0x%08x\n", omap_readl(OMAP32_ID_1));
> -	printk("JTAG_ID: 0x%04x DIE_REV: %i\n", jtag_id, die_rev);
> +	printk(KERN_DEBUG "OMAP32_ID_0: 0x%08x\n", omap_readl(OMAP32_ID_0));
> +	printk(KERN_DEBUG "OMAP32_ID_1: 0x%08x\n", omap_readl(OMAP32_ID_1));
> +	printk(KERN_DEBUG "JTAG_ID: 0x%04x DIE_REV: %i\n", jtag_id, die_rev);
>  #endif

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2006-05-26 11:51 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
2006-05-15 12:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
2006-05-15 12:20 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Christophe Lucas
2006-05-15 14:34 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
2006-05-18  8:08 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Arthur Othieno
2006-05-18  8:10 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Arthur Othieno
2006-05-18  8:15 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Arthur Othieno
2006-05-18  8:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Arthur Othieno
2006-05-18  8:25 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
2006-05-18  8:30 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
2006-05-18  8:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
2006-05-26 10:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/id.c Christophe Lucas
2006-05-26 11:51 ` Alexey Dobriyan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.