Re: [PATCH] Add ata_piix's own resume function

[Jens Axboe <axboe@suse.de>]

On Sat, May 27 2006, Jeff Garzik wrote:
> Jens Axboe wrote:
> >I thought about that, and I don't agree. Waiting for the BSY to clear is
> >not a pci property, at best I'd consider that even worse than defining a
> >scsi resume function in ata_piix.
> 
> It has nothing to do with PCI, and everything to do control flow.  This 
> is _how the hardware works_:

It does by the very nature of this being invoked by the pci device
resume function...

> First you resume the controller.
> Then you resume the bus.
> Then you resume the devices on the bus.
> 
> The original patch goes BACKWARDS, by trying to resume the bus from the 
> device resume method.  That's just dumb.

Since there's just the one device on the bus in this case, whether its
the device or bus posting BUSY seems pretty irrelevant. If anything, I'd
say that the act of iterating over possible devices hanging of the pci
device and resuming them from the pci handler is definitely the worst
approach. The pci driver resume function should do just one thing --
resume the device itself.

-- 
Jens Axboe