All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Jens Axboe <axboe@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Jeff Garzik <jeff@garzik.org>,
	"zhao, forrest" <forrest.zhao@intel.com>,
	Tejun Heo <htejun@gmail.com>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue
Date: Sat, 27 May 2006 19:10:31 -0400	[thread overview]
Message-ID: <4478DC67.6050800@rtr.ca> (raw)
In-Reply-To: <20060527225316.GA1075@suse.de>

Jens Axboe wrote:
> +               u8 status1, status2, status3;
> +               status1 = ata_chk_status(ap);
> +               ata_busy_wait(ap, ATA_BUSY, 200000);
> +               status2 = ata_chk_status(ap);
> +               status3 = ata_wait_idle(ap);
> +               printk("s 1/2/3 %x/%x/%x\n", status1, status2, status3);
> 
> with the rest being as posted before. It gives me:
> 
> s 1/2/3 80/50/50 on resume.
...

> With that hunk restored to normal, no change. Resume still works, status
> is still 80/50/50.

So, just the "status1 = ata_chk_status(ap);" seems to be enough
to make it work for you, in place of the earlier 500msec delay we started with?

Curious.

Does it still work when the "status1 = ata_chk_status(ap);" is replaced with udelay(1) ??


  parent reply	other threads:[~2006-05-27 23:10 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26  9:04 [PATCH] Add ata_piix's own resume function zhao, forrest
2006-05-26 23:05 ` Jens Axboe
2006-05-26 23:28   ` Jeff Garzik
2006-05-26 23:38     ` Jeff Garzik
2006-05-26 23:50       ` Jeff Garzik
2006-05-27  6:21     ` Jens Axboe
2006-05-27  6:31       ` Jeff Garzik
2006-05-27  6:46         ` Jens Axboe
2006-05-27  6:52           ` Jeff Garzik
2006-05-27  3:22   ` 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue Mark Lord
2006-05-27  3:32     ` Linus Torvalds
2006-05-27  3:41       ` Jeff Garzik
2006-05-27  4:00       ` [PATCH] " Jeff Garzik
2006-05-27 18:23         ` Mark Lord
2006-05-27 18:47           ` Linus Torvalds
2006-05-27 19:01             ` Jeff Garzik
2006-05-27 19:06               ` Jeff Garzik
2006-05-27 19:01             ` Mark Lord
2006-05-27 20:45             ` Jens Axboe
2006-05-27 20:58               ` Jeff Garzik
2006-05-27 21:11                 ` Jens Axboe
2006-05-27 21:17                   ` Jeff Garzik
2006-05-27 21:20                     ` Jens Axboe
2006-05-27 21:23                       ` Mark Lord
2006-05-27 21:25                         ` Jens Axboe
2006-05-27 21:30                         ` Mark Lord
2006-05-27 21:24                       ` Jeff Garzik
2006-05-27 21:26                         ` Jens Axboe
2006-05-27 21:31                         ` Mark Lord
2006-05-27 21:32                           ` Jeff Garzik
2006-05-27 21:33                         ` Jens Axboe
2006-05-27 21:34                           ` Jeff Garzik
2006-05-27 21:37                             ` Mark Lord
2006-05-27 21:51                               ` Jeff Garzik
2006-05-27 21:41                             ` Tejun Heo
2006-05-27 21:45                               ` Jeff Garzik
2006-05-27 21:38                       ` Linus Torvalds
2006-05-27 21:50                         ` Jeff Garzik
2006-05-27 21:57                           ` Linus Torvalds
2006-05-27 22:11                             ` Jeff Garzik
2006-05-27 21:50                       ` Linus Torvalds
2006-05-27 21:53                         ` Jeff Garzik
2006-05-27 22:14                           ` Linus Torvalds
2006-05-27 22:06                         ` Mark Lord
2006-05-27 22:11                           ` Jens Axboe
2006-05-27 22:13                             ` Jeff Garzik
2006-05-27 22:15                               ` Jens Axboe
2006-05-27 22:15                             ` Mark Lord
2006-05-27 22:17                               ` Jens Axboe
2006-05-27 22:21                             ` Linus Torvalds
2006-05-27 22:29                               ` Mark Lord
2006-05-27 22:36                                 ` Jens Axboe
2006-05-27 22:48                                   ` Mark Lord
2006-05-27 22:53                                     ` Jens Axboe
2006-05-27 22:55                                       ` Jeff Garzik
2006-05-27 23:10                                       ` Mark Lord [this message]
2006-05-28  0:24                                         ` Linus Torvalds
2006-05-28  0:26                                           ` Linus Torvalds
2006-05-28  0:56                                             ` Jeff Garzik
2006-05-28  0:35                                           ` Linus Torvalds
2006-05-28  0:51                                           ` Mark Lord
2006-05-28  0:53                                           ` Jeff Garzik
2006-05-28  0:56                                             ` Mark Lord
2006-05-28  1:01                                             ` Linus Torvalds
2006-05-28  1:03                                               ` Jeff Garzik
2006-05-28  1:01                                           ` Jeff Garzik
2006-05-28 15:28                                             ` [PATCH] 2.6.17-rc5: the latest consensus libata resume fix Mark Lord
2006-05-28 17:14                                               ` Jens Axboe
2006-05-28 19:05                                                 ` Jeff Garzik
2006-05-28 19:18                                                   ` Mark Lord
2006-05-28 20:10                                                     ` Jeff Garzik
2006-05-28 20:27                                                       ` Mark Lord
2006-05-28 22:28                                                       ` Jens Axboe
2006-05-29  1:28                                                         ` Jeff Garzik
2006-05-29  2:53                                                           ` Mark Lord
2006-05-29  3:18                                                             ` Jeff Garzik
2006-05-29  3:28                                                           ` zhao, forrest
2006-05-29  2:43                                                         ` Mark Lord
2006-05-27 22:35                               ` [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue Jens Axboe
2006-05-27 22:52                                 ` Jeff Garzik
2006-05-27 22:54                                   ` Jens Axboe
2006-05-27 23:06                                     ` Jens Axboe
2006-05-27 22:56                                   ` Mark Lord
2006-05-27 23:03                                     ` Jeff Garzik
2006-05-27 22:18                           ` Linus Torvalds
2006-05-27 22:23                             ` Mark Lord
2006-05-27 22:43                               ` Mark Lord
2006-05-28  0:13                               ` Linus Torvalds
2006-05-27 18:54           ` Jeff Garzik
2006-05-27 19:08             ` Mark Lord
2006-05-27 19:15               ` Jeff Garzik
2006-05-27 19:24                 ` Mark Lord
2006-05-27 20:24                   ` Jens Axboe
2006-05-27  6:29       ` Jens Axboe
2006-05-27  6:36         ` Jeff Garzik
2006-05-27  7:01           ` Jens Axboe
2006-05-27  7:06             ` Jeff Garzik
2006-05-27 18:46         ` Mark Lord
2006-05-27  3:35     ` Jeff Garzik
2006-05-27  6:20     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4478DC67.6050800@rtr.ca \
    --to=liml@rtr.ca \
    --cc=axboe@suse.de \
    --cc=forrest.zhao@intel.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.