Re: [PATCH] 2.6.17-rc5: the latest consensus libata resume fix

[Jeff Garzik <jeff@garzik.org>]

Jens Axboe wrote:
> On Sun, May 28 2006, Mark Lord wrote:
>> Okay, just to sum things up.
>>
>> The patch below is the current "release candidate" for
>> improving the libata/ata_piix resume functionality in 2.6.17-rc*.
>>
>> It forces libata to wait for up to 2 seconds for BUSY|DRQ to clear
>> on resume before continuing.  This is only for 2.6.17 at present.
>>
>> We are waiting on Jens to test and report back for this specific version.
>>
>> Signed-off-by:  Mark Lord <liml@rtr.ca>
>> ---
>> --- linux-2.6.17-rc5/drivers/scsi/libata-core.c
>> +++ linux/drivers/scsi/libata-core.c
>> @@ -4296,6 +4296,7 @@ static int ata_start_drive(struct ata_po
>>   */
>>  int ata_device_resume(struct ata_port *ap, struct ata_device *dev)
>>  {
>>  	if (ap->flags & ATA_FLAG_SUSPENDED) {
>> +		ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 200000);
>>  		ap->flags &= ~ATA_FLAG_SUSPENDED;
>>  		ata_set_mode(ap);
> 
> Sorry for the unresponsiveness, still away and internet connectivity
> spotty. Just tested the above, and it works for me! I think Marks
> analisys wrt DRQ is completely correct and this validates it.

Does your box work without ATA_DRQ?

	Jeff