From: Al Viro <viro@ftp.linux.org.uk>
To: Josh Triplett <josh@freedesktop.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-sparse@vger.kernel.org
Subject: Re: [patchset] rewrite of initializer handling
Date: Mon, 18 Jun 2007 20:30:26 +0100 [thread overview]
Message-ID: <20070618193026.GH21478@ftp.linux.org.uk> (raw)
In-Reply-To: <4676C8CF.6020201@freedesktop.org>
On Mon, Jun 18, 2007 at 11:02:55AM -0700, Josh Triplett wrote:
> Yeah, I've observed the same thing from activity in both the kernel community
> and the Sparse community. I still look at the patches, but primarily so I
> can understand them and learn something from them, not because I expect to
> find anything wrong. :)
That's never a good idea, no matter where the patches are coming from.
Odds are that you have a different set of blind spots, so having "why
isn't that broken here?" as background attitude while reading any code
tends to find exactly the crap that happens to be hard to find for author
of the code in question...
next prev parent reply other threads:[~2007-06-18 19:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 10:19 [patchset] rewrite of initializer handling Al Viro
2007-06-18 10:26 ` Al Viro
2007-06-18 17:07 ` Linus Torvalds
2007-06-18 18:02 ` Josh Triplett
2007-06-18 19:30 ` Al Viro [this message]
2007-06-18 18:19 ` Josh Triplett
2007-06-18 19:16 ` Al Viro
2007-06-18 19:27 ` Linus Torvalds
2007-06-18 21:46 ` Michael Stefaniuc
2007-06-18 22:43 ` Al Viro
2007-06-19 9:47 ` Michael Stefaniuc
2007-06-19 20:15 ` Michael Stefaniuc
2007-06-19 22:41 ` Al Viro
2007-06-20 8:54 ` Michael Stefaniuc
2007-06-20 21:29 ` Michael Stefaniuc
-- strict thread matches above, loose matches on Subject: below --
2007-06-19 17:12 Alexey Dobriyan
2007-06-19 17:21 ` Al Viro
2007-06-19 22:33 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618193026.GH21478@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.