From: Michael Stefaniuc <mstefani@redhat.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Josh Triplett <josh@freedesktop.org>, linux-sparse@vger.kernel.org
Subject: Re: [patchset] rewrite of initializer handling
Date: Wed, 20 Jun 2007 10:54:02 +0200 [thread overview]
Message-ID: <4678EB2A.7000106@redhat.com> (raw)
In-Reply-To: <20070619224125.GP21478@ftp.linux.org.uk>
Al Viro wrote:
> On Tue, Jun 19, 2007 at 10:15:49PM +0200, Michael Stefaniuc wrote:
>> Not sure if this is a poll but -Wparen-string doesn't add any new
>> warnings to the Wine run. And Wine has a "strange" way of specifying
>> wide char strings.
>
> Oh? FWIW, C99 way is L"......" for wide string literals and L'...' for
I know but that is not portable. A wchar is 16bit on Windows and 32bit
in the normal world. gcc has the -fshort-wchar switch to make a wchar
16bit but that still produces problems; afair when bridging between the
hosts native 32bit wchar and Windows 16bit wchar. To avoid that Wine uses:
WCHAR s[] = {'H','e','l','l','o',' ','W','o','r','l','d',0};
> wide character ones. sparse doesn't handle either and I'm not sure if
> we really want to open that can of worms...
There are only 6 .c files (out of around 2000) that do not parse in Wine
due to missing support wide char character constant / string literal.
I had a look at sparse on how to fix it but it seems to require more
than some trivial changes. I mean to implement it correctly and not just
to stop sparse from mis parsing the rest of the file too.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer Fax.: +49-711-96437-111
Red Hat GmbH Email: mstefani@redhat.com
Hauptstaetterstr. 58 http://www.redhat.de/
D-70178 Stuttgart
next prev parent reply other threads:[~2007-06-20 8:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 10:19 [patchset] rewrite of initializer handling Al Viro
2007-06-18 10:26 ` Al Viro
2007-06-18 17:07 ` Linus Torvalds
2007-06-18 18:02 ` Josh Triplett
2007-06-18 19:30 ` Al Viro
2007-06-18 18:19 ` Josh Triplett
2007-06-18 19:16 ` Al Viro
2007-06-18 19:27 ` Linus Torvalds
2007-06-18 21:46 ` Michael Stefaniuc
2007-06-18 22:43 ` Al Viro
2007-06-19 9:47 ` Michael Stefaniuc
2007-06-19 20:15 ` Michael Stefaniuc
2007-06-19 22:41 ` Al Viro
2007-06-20 8:54 ` Michael Stefaniuc [this message]
2007-06-20 21:29 ` Michael Stefaniuc
-- strict thread matches above, loose matches on Subject: below --
2007-06-19 17:12 Alexey Dobriyan
2007-06-19 17:21 ` Al Viro
2007-06-19 22:33 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4678EB2A.7000106@redhat.com \
--to=mstefani@redhat.com \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.