Re: [patchset] rewrite of initializer handling

[Michael Stefaniuc <mstefani@redhat.com>]

Michael Stefaniuc wrote:
> Al Viro wrote:
>> On Tue, Jun 19, 2007 at 10:15:49PM +0200, Michael Stefaniuc wrote:
>>> Not sure if this is a poll but -Wparen-string doesn't add any new
>>> warnings to the Wine run. And Wine has a "strange" way of specifying
>>> wide char strings.
>>
>> Oh?  FWIW, C99 way is L"......" for wide string literals and L'...' for
> I know but that is not portable. A wchar is 16bit on Windows and 32bit
> in the normal world. gcc has the -fshort-wchar switch to make a wchar
> 16bit but that still produces problems; afair when bridging between the
> hosts native 32bit wchar and Windows 16bit wchar. To avoid that Wine uses:
> WCHAR s[] = {'H','e','l','l','o',' ','W','o','r','l','d',0};
> 
>> wide character ones.  sparse doesn't handle either and I'm not sure if
>> we really want to open that can of worms...
> There are only 6 .c files (out of around 2000) that do not parse in Wine
> due to missing support wide char character constant / string literal.
> I had a look at sparse on how to fix it but it seems to require more
> than some trivial changes. I mean to implement it correctly and not just
> to stop sparse from mis parsing the rest of the file too.
Duh ... my bad; i should have looked better. The files i thought sparse
 mis parses after it encounters the L'...' have a lot of wide character
constants in them thus giving the impression that sparse would not be
recovering from the error.

bye
	michael
-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani@redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart