Re: [patchset] rewrite of initializer handling

[Michael Stefaniuc <mstefani@redhat.com>]

Al Viro wrote:
> On Mon, Jun 18, 2007 at 11:19:08AM -0700, Josh Triplett wrote:
>> How much spew does -Wparen-string cause?  If you feel that it always
>> represents an error, or at least sloppy code, and that it won't drown people
>> in warnings, I have no problem with turning it on by default.  Your call.
> 
> Depends on a project.  In case of kernel it's mostly a spew in s2io.c
> around
> static char ethtool_driver_stats_keys[][ETH_GSTRING_LEN] = {
>         {"\n DRIVER STATISTICS"},
>         {"single_bit_ecc_errs"},
>         {"double_bit_ecc_errs"},
>         {"parity_err_cnt"},
>         {"serious_err_cnt"},
>         {"soft_reset_cnt"},
>         {"fifo_full_cnt"},
>         {"ring_full_cnt"},
>         ("alarm_transceiver_temp_high"),
>         ("alarm_transceiver_temp_low"),
>         ("alarm_laser_bias_current_high"),
>         ("alarm_laser_bias_current_low"),
>         ("alarm_laser_output_power_high"),
> ....
> 
> Mind you, both braces and parentheses are redundant here, but the latter
> happen to be invalid C as well (and we want at least consistency anyway).
> 
> Other projects may differ.  IOW, I'd probably keep it optional.
Not sure if this is a poll but -Wparen-string doesn't add any new
warnings to the Wine run. And Wine has a "strange" way of specifying
wide char strings.

bye
	michael
-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani@redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart