From: Olaf Hering <olh@suse.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Robert Hancock <hancockr@shaw.ca>,
stable@kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping"
Date: Mon, 6 Aug 2007 13:58:04 +0200 [thread overview]
Message-ID: <20070806115804.GA1734@suse.de> (raw)
In-Reply-To: <46B5824B.1000103@s5r6.in-berlin.de>
On Sun, Aug 05, Stefan Richter wrote:
> Benjamin Herrenschmidt wrote:
> >>> If setting 32-bit DMA mask fails on ppc64, that sounds like a problem
> >>> with the DMA implementation on that architecture. There are enough cards
> >>> out there that only support 32-bit DMA that this really needs to work..
> >> Yes, could the PPC folks please have a look at it? Thanks.
> >
> > Smells like we may have a bug there. No worries though, all current PPC
> > machines have an iommu that will not give out addresses above 32 bits
> > anyway, but I'll double check what's up.
> >
> > Do you see something in dmesg when that happens ?
>
> There was nothing in Olaf's report, except for trouble in sbp2 _after_
> the failure. http://lkml.org/lkml/2007/8/1/344 (I don't have a PMac.)
sbp2util_remove_command_orb_pool() does not check for lu->hi being NULL.
dev->dma_mask is NULL too, thats why dma_direct_dma_supported() returns
false, and dma_set_mask() will return -EIO.
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olh@suse.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Robert Hancock <hancockr@shaw.ca>,
linuxppc-dev@ozlabs.org, stable@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping"
Date: Mon, 6 Aug 2007 13:58:04 +0200 [thread overview]
Message-ID: <20070806115804.GA1734@suse.de> (raw)
In-Reply-To: <46B5824B.1000103@s5r6.in-berlin.de>
On Sun, Aug 05, Stefan Richter wrote:
> Benjamin Herrenschmidt wrote:
> >>> If setting 32-bit DMA mask fails on ppc64, that sounds like a problem
> >>> with the DMA implementation on that architecture. There are enough cards
> >>> out there that only support 32-bit DMA that this really needs to work..
> >> Yes, could the PPC folks please have a look at it? Thanks.
> >
> > Smells like we may have a bug there. No worries though, all current PPC
> > machines have an iommu that will not give out addresses above 32 bits
> > anyway, but I'll double check what's up.
> >
> > Do you see something in dmesg when that happens ?
>
> There was nothing in Olaf's report, except for trouble in sbp2 _after_
> the failure. http://lkml.org/lkml/2007/8/1/344 (I don't have a PMac.)
sbp2util_remove_command_orb_pool() does not check for lu->hi being NULL.
dev->dma_mask is NULL too, thats why dma_direct_dma_supported() returns
false, and dma_set_mask() will return -EIO.
next prev parent reply other threads:[~2007-08-06 11:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.Qn3Snqoik3hhnxcA6HqjGV0Yzck@ifi.uio.no>
2007-08-04 17:14 ` [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Robert Hancock
2007-08-04 17:30 ` Stefan Richter
2007-08-04 17:30 ` Stefan Richter
2007-08-05 0:15 ` Benjamin Herrenschmidt
2007-08-05 0:15 ` Benjamin Herrenschmidt
2007-08-05 7:54 ` Stefan Richter
2007-08-05 7:54 ` Stefan Richter
2007-08-05 22:04 ` Benjamin Herrenschmidt
2007-08-05 22:04 ` Benjamin Herrenschmidt
2007-08-06 13:51 ` Olaf Hering
2007-08-06 13:51 ` Olaf Hering
2007-08-06 21:47 ` Benjamin Herrenschmidt
2007-08-06 21:47 ` Benjamin Herrenschmidt
2007-08-06 22:22 ` Stefan Richter
2007-08-06 22:22 ` Stefan Richter
2007-08-06 22:25 ` Robert Hancock
2007-08-06 22:25 ` Robert Hancock
2007-08-06 22:32 ` Benjamin Herrenschmidt
2007-08-06 22:32 ` Benjamin Herrenschmidt
2007-08-06 22:35 ` Robert Hancock
2007-08-06 22:35 ` Robert Hancock
2007-08-06 22:59 ` Stefan Richter
2007-08-06 22:59 ` Stefan Richter
2007-08-06 22:48 ` Stefan Richter
2007-08-06 22:48 ` Stefan Richter
2007-08-07 2:18 ` Andi Kleen
2007-08-07 2:18 ` Andi Kleen
2007-08-06 22:29 ` Benjamin Herrenschmidt
2007-08-06 22:29 ` Benjamin Herrenschmidt
2007-08-06 11:58 ` Olaf Hering [this message]
2007-08-06 11:58 ` Olaf Hering
2007-08-06 21:43 ` Benjamin Herrenschmidt
2007-08-06 21:43 ` Benjamin Herrenschmidt
2007-08-06 22:05 ` [PATCH] powerpc: Fix initialization and usage of dma_mask Benjamin Herrenschmidt
2007-08-06 22:05 ` Benjamin Herrenschmidt
2007-08-06 22:30 ` Olaf Hering
2007-08-06 22:30 ` Olaf Hering
2007-08-04 16:39 [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806115804.GA1734@suse.de \
--to=olh@suse.de \
--cc=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stable@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.