From: Olaf Hering <olh@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Robert Hancock <hancockr@shaw.ca>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Paul Mackerras <paulus@samba.org>,
stable@kernel.org
Subject: Re: [PATCH] powerpc: Fix initialization and usage of dma_mask
Date: Tue, 7 Aug 2007 00:30:19 +0200 [thread overview]
Message-ID: <20070806223019.GA19389@suse.de> (raw)
In-Reply-To: <1186437910.938.79.camel@localhost.localdomain>
On Tue, Aug 07, Benjamin Herrenschmidt wrote:
> powerpc has a couple of bugs in the usage of dma_masks that tend to
> break when drivers explicitely try to set a 32 bits mask for example.
>
> First the code that generates the pci devices from the OF device-tree
> doesn't initialize the mask properly, then our implementation of
> set_dma_mask() was trying to validate the -previous- mask value, not the
> one passed in as an argument.
>
> This patch should fix these.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Does this fix the problem you've noticed ?
This patch fixes it. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olh@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Robert Hancock <hancockr@shaw.ca>,
linuxppc-dev@ozlabs.org, stable@kernel.org,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Fix initialization and usage of dma_mask
Date: Tue, 7 Aug 2007 00:30:19 +0200 [thread overview]
Message-ID: <20070806223019.GA19389@suse.de> (raw)
In-Reply-To: <1186437910.938.79.camel@localhost.localdomain>
On Tue, Aug 07, Benjamin Herrenschmidt wrote:
> powerpc has a couple of bugs in the usage of dma_masks that tend to
> break when drivers explicitely try to set a 32 bits mask for example.
>
> First the code that generates the pci devices from the OF device-tree
> doesn't initialize the mask properly, then our implementation of
> set_dma_mask() was trying to validate the -previous- mask value, not the
> one passed in as an argument.
>
> This patch should fix these.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Does this fix the problem you've noticed ?
This patch fixes it. Thanks.
next prev parent reply other threads:[~2007-08-06 22:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.Qn3Snqoik3hhnxcA6HqjGV0Yzck@ifi.uio.no>
2007-08-04 17:14 ` [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Robert Hancock
2007-08-04 17:30 ` Stefan Richter
2007-08-04 17:30 ` Stefan Richter
2007-08-05 0:15 ` Benjamin Herrenschmidt
2007-08-05 0:15 ` Benjamin Herrenschmidt
2007-08-05 7:54 ` Stefan Richter
2007-08-05 7:54 ` Stefan Richter
2007-08-05 22:04 ` Benjamin Herrenschmidt
2007-08-05 22:04 ` Benjamin Herrenschmidt
2007-08-06 13:51 ` Olaf Hering
2007-08-06 13:51 ` Olaf Hering
2007-08-06 21:47 ` Benjamin Herrenschmidt
2007-08-06 21:47 ` Benjamin Herrenschmidt
2007-08-06 22:22 ` Stefan Richter
2007-08-06 22:22 ` Stefan Richter
2007-08-06 22:25 ` Robert Hancock
2007-08-06 22:25 ` Robert Hancock
2007-08-06 22:32 ` Benjamin Herrenschmidt
2007-08-06 22:32 ` Benjamin Herrenschmidt
2007-08-06 22:35 ` Robert Hancock
2007-08-06 22:35 ` Robert Hancock
2007-08-06 22:59 ` Stefan Richter
2007-08-06 22:59 ` Stefan Richter
2007-08-06 22:48 ` Stefan Richter
2007-08-06 22:48 ` Stefan Richter
2007-08-07 2:18 ` Andi Kleen
2007-08-07 2:18 ` Andi Kleen
2007-08-06 22:29 ` Benjamin Herrenschmidt
2007-08-06 22:29 ` Benjamin Herrenschmidt
2007-08-06 11:58 ` Olaf Hering
2007-08-06 11:58 ` Olaf Hering
2007-08-06 21:43 ` Benjamin Herrenschmidt
2007-08-06 21:43 ` Benjamin Herrenschmidt
2007-08-06 22:05 ` [PATCH] powerpc: Fix initialization and usage of dma_mask Benjamin Herrenschmidt
2007-08-06 22:05 ` Benjamin Herrenschmidt
2007-08-06 22:30 ` Olaf Hering [this message]
2007-08-06 22:30 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806223019.GA19389@suse.de \
--to=olh@suse.de \
--cc=benh@kernel.crashing.org \
--cc=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.