From: Andrew Morton <akpm@linux-foundation.org>
To: Takashi Sato <t-sato@yk.jp.nec.com>
Cc: axboe@kernel.dk, mtk.manpages@googlemail.com,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
dm-devel@redhat.com, viro@ZenIV.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] Add timeout feature
Date: Sun, 29 Jun 2008 17:01:52 -0700 [thread overview]
Message-ID: <20080629170152.aa769918.akpm@linux-foundation.org> (raw)
In-Reply-To: <C2E97AF9310E467696FA7F4C62C88AC5@nsl.ad.nec.co.jp>
On Mon, 30 Jun 2008 08:13:07 +0900 "Takashi Sato" <t-sato@yk.jp.nec.com> wrote:
> > It's much better to use NULL here rather than literal zero because the
> > reader of this code can then say "ah-hah, we're passing in a pointer".
> > Whereas plain old "0" could be a pointer or a scalar.
>
> The second argument's type of freeze_bdev() is "long", not pointer as below.
> struct super_block *freeze_bdev(struct block_device *, long timeout_msec);
oh, ok, I goofed, sorry.
> So "0" is reasonable, isn't it?
yup.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Takashi Sato <t-sato@yk.jp.nec.com>
Cc: viro@ZenIV.linux.org.uk, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk, mtk.manpages@googlemail.com
Subject: Re: [PATCH 3/3] Add timeout feature
Date: Sun, 29 Jun 2008 17:01:52 -0700 [thread overview]
Message-ID: <20080629170152.aa769918.akpm@linux-foundation.org> (raw)
In-Reply-To: <C2E97AF9310E467696FA7F4C62C88AC5@nsl.ad.nec.co.jp>
On Mon, 30 Jun 2008 08:13:07 +0900 "Takashi Sato" <t-sato@yk.jp.nec.com> wrote:
> > It's much better to use NULL here rather than literal zero because the
> > reader of this code can then say "ah-hah, we're passing in a pointer".
> > Whereas plain old "0" could be a pointer or a scalar.
>
> The second argument's type of freeze_bdev() is "long", not pointer as below.
> struct super_block *freeze_bdev(struct block_device *, long timeout_msec);
oh, ok, I goofed, sorry.
> So "0" is reasonable, isn't it?
yup.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Takashi Sato" <t-sato@yk.jp.nec.com>
Cc: <viro@ZenIV.linux.org.uk>, <linux-ext4@vger.kernel.org>,
<xfs@oss.sgi.com>, <dm-devel@redhat.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<axboe@kernel.dk>, <mtk.manpages@googlemail.com>
Subject: Re: [PATCH 3/3] Add timeout feature
Date: Sun, 29 Jun 2008 17:01:52 -0700 [thread overview]
Message-ID: <20080629170152.aa769918.akpm@linux-foundation.org> (raw)
In-Reply-To: <C2E97AF9310E467696FA7F4C62C88AC5@nsl.ad.nec.co.jp>
On Mon, 30 Jun 2008 08:13:07 +0900 "Takashi Sato" <t-sato@yk.jp.nec.com> wrote:
> > It's much better to use NULL here rather than literal zero because the
> > reader of this code can then say "ah-hah, we're passing in a pointer".
> > Whereas plain old "0" could be a pointer or a scalar.
>
> The second argument's type of freeze_bdev() is "long", not pointer as below.
> struct super_block *freeze_bdev(struct block_device *, long timeout_msec);
oh, ok, I goofed, sorry.
> So "0" is reasonable, isn't it?
yup.
next prev parent reply other threads:[~2008-06-30 0:01 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 7:00 [PATCH 3/3] Add timeout feature Takashi Sato
2008-06-24 7:00 ` Takashi Sato
2008-06-24 22:09 ` Andrew Morton
2008-06-27 11:33 ` Takashi Sato
2008-06-27 11:33 ` Takashi Sato
2008-06-27 11:33 ` Takashi Sato
2008-06-27 18:57 ` Andrew Morton
2008-06-29 23:13 ` Takashi Sato
2008-06-29 23:13 ` Takashi Sato
2008-06-29 23:13 ` Takashi Sato
2008-06-30 0:01 ` Andrew Morton [this message]
2008-06-30 0:01 ` Andrew Morton
2008-06-30 0:01 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2008-06-30 12:24 Takashi Sato
2008-06-30 12:24 ` Takashi Sato
2008-07-01 8:10 ` Christoph Hellwig
2008-07-07 11:07 ` Pavel Machek
2008-07-08 23:10 ` Dave Chinner
2008-07-08 23:10 ` Dave Chinner
2008-07-08 23:20 ` Pavel Machek
2008-07-08 23:20 ` Pavel Machek
2008-07-08 23:20 ` Pavel Machek
2008-07-09 0:52 ` Dave Chinner
2008-07-09 1:09 ` Theodore Tso
2008-07-09 1:09 ` Theodore Tso
2008-07-09 1:09 ` Theodore Tso
2008-07-09 4:21 ` Brad Boyer
2008-07-09 4:21 ` Brad Boyer
2008-07-09 4:21 ` Brad Boyer
2008-07-09 4:21 ` Brad Boyer
2008-07-09 6:13 ` Miklos Szeredi
2008-07-09 6:16 ` Christoph Hellwig
2008-07-09 6:22 ` Miklos Szeredi
2008-07-09 6:22 ` Miklos Szeredi
2008-07-09 6:22 ` Miklos Szeredi
2008-07-09 6:41 ` Arjan van de Ven
2008-07-09 6:41 ` Arjan van de Ven
2008-07-09 6:41 ` Arjan van de Ven
2008-07-09 6:48 ` Miklos Szeredi
2008-07-09 6:48 ` Miklos Szeredi
2008-07-09 6:55 ` Arjan van de Ven
2008-07-09 6:55 ` Arjan van de Ven
2008-07-09 6:55 ` Arjan van de Ven
2008-07-09 7:08 ` Miklos Szeredi
2008-07-09 7:08 ` Miklos Szeredi
2008-07-09 20:48 ` Pavel Machek
2008-07-09 7:13 ` Dave Chinner
2008-07-09 11:09 ` Theodore Tso
2008-07-09 11:09 ` Theodore Tso
2008-07-09 11:49 ` Dave Chinner
2008-07-09 11:49 ` Dave Chinner
2008-07-09 12:24 ` Theodore Tso
2008-07-09 12:24 ` Theodore Tso
2008-07-09 12:59 ` Olaf Frączyk
2008-07-09 13:57 ` Arjan van de Ven
2008-07-09 13:57 ` Arjan van de Ven
2008-07-09 12:24 ` Theodore Tso
2008-07-09 13:55 ` Arjan van de Ven
2008-07-09 13:58 ` jim owens
2008-07-09 14:13 ` jim owens
2008-07-13 12:06 ` Pavel Machek
2008-07-13 17:15 ` jim owens
2008-07-14 6:36 ` Pavel Machek
2008-07-14 13:17 ` jim owens
2008-07-14 13:12 ` Takashi Sato
2008-07-14 13:12 ` Takashi Sato
2008-07-14 14:04 ` jim owens
2008-07-09 11:49 ` Dave Chinner
2008-07-09 11:49 ` Dave Chinner
2008-07-09 11:09 ` Theodore Tso
2008-07-09 13:53 ` Arjan van de Ven
2008-07-09 6:59 ` Dave Chinner
2008-07-09 7:13 ` Miklos Szeredi
2008-07-09 7:33 ` Dave Chinner
2008-07-09 7:33 ` Dave Chinner
2008-07-09 8:11 ` Miklos Szeredi
2008-07-09 8:11 ` Miklos Szeredi
2008-07-09 11:15 ` Dave Chinner
2008-07-09 11:15 ` Dave Chinner
2008-07-09 1:09 ` Theodore Tso
2008-07-09 20:44 ` Pavel Machek
2008-07-09 20:44 ` Pavel Machek
2008-07-09 20:44 ` Pavel Machek
2008-07-09 20:44 ` Pavel Machek
2008-07-08 23:20 ` Pavel Machek
2008-07-22 9:36 Takashi Sato
2008-07-22 9:36 ` Takashi Sato
2008-07-22 9:36 ` Takashi Sato
2008-07-22 9:36 Takashi Sato
2008-08-18 12:28 Takashi Sato
2008-08-18 12:28 ` Takashi Sato
2008-08-21 20:20 ` Andrew Morton
2008-08-21 20:20 ` Andrew Morton
2008-08-22 18:16 ` Christoph Hellwig
2008-08-22 18:16 ` Christoph Hellwig
2008-08-24 17:03 ` Oleg Nesterov
2008-08-29 9:39 ` Takashi Sato
2008-08-29 9:39 ` Takashi Sato
2008-08-29 9:39 ` Takashi Sato
2008-09-08 11:53 Takashi Sato
2008-09-08 11:53 ` Takashi Sato
2008-09-08 17:11 ` Christoph Hellwig
2008-09-25 21:06 ` Ric Wheeler
2008-09-26 8:52 ` Takashi Sato
2008-09-26 8:52 ` Takashi Sato
2008-09-26 10:58 ` Ric Wheeler
2008-09-29 11:11 ` Takashi Sato
2008-09-29 11:11 ` Takashi Sato
2008-09-29 11:11 ` Takashi Sato
2008-09-26 12:35 ` Valdis.Kletnieks
2008-09-26 12:35 ` Valdis.Kletnieks
2008-09-29 14:13 ` Christoph Hellwig
2008-09-29 14:36 ` Eric Sandeen
2008-09-29 14:36 ` Eric Sandeen
2008-09-29 14:37 ` Christoph Hellwig
2008-09-29 14:45 ` Eric Sandeen
2008-09-29 22:08 ` jim owens
2008-10-05 10:00 ` Pavel Machek
2008-10-09 10:12 ` Takashi Sato
2008-10-09 10:12 ` Takashi Sato
2008-10-09 10:12 ` Takashi Sato
2008-10-09 10:18 ` Christoph Hellwig
2008-10-09 10:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080629170152.aa769918.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@googlemail.com \
--cc=t-sato@yk.jp.nec.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.