From: Ingo Molnar <mingo@elte.hu>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT
Date: Fri, 3 Oct 2008 10:02:44 +0200 [thread overview]
Message-ID: <20081003080244.GC25408@elte.hu> (raw)
In-Reply-To: <1223017469-5158-1-git-send-email-kirill@shutemov.name>
* Kirill A. Shutemov <kirill@shutemov.name> wrote:
> - /* for MAP_32BIT mappings we force the legact mmap base */
> - if (!test_thread_flag(TIF_IA32) && (flags & MAP_32BIT))
> + /* for MAP_32BIT mappings and ADDR_LIMIT_32BIT personality we force the
> + * legact mmap base
> + */
please use the customary multi-line comment style:
/*
* Comment .....
* ...... goes here:
*/
and you might use the opportunity to fix the s/legact/legacy typo as
well.
but more generally, we already have ADDR_LIMIT_3GB support on x86. Why
should support for ADDR_LIMIT_32BIT be added?
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT
Date: Fri, 3 Oct 2008 10:02:44 +0200 [thread overview]
Message-ID: <20081003080244.GC25408@elte.hu> (raw)
In-Reply-To: <1223017469-5158-1-git-send-email-kirill@shutemov.name>
* Kirill A. Shutemov <kirill@shutemov.name> wrote:
> - /* for MAP_32BIT mappings we force the legact mmap base */
> - if (!test_thread_flag(TIF_IA32) && (flags & MAP_32BIT))
> + /* for MAP_32BIT mappings and ADDR_LIMIT_32BIT personality we force the
> + * legact mmap base
> + */
please use the customary multi-line comment style:
/*
* Comment .....
* ...... goes here:
*/
and you might use the opportunity to fix the s/legact/legacy typo as
well.
but more generally, we already have ADDR_LIMIT_3GB support on x86. Why
should support for ADDR_LIMIT_32BIT be added?
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-03 8:03 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 7:04 [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT Kirill A. Shutemov
2008-10-03 7:04 ` Kirill A. Shutemov
2008-10-03 8:02 ` Ingo Molnar [this message]
2008-10-03 8:02 ` Ingo Molnar
2008-10-03 9:25 ` Kirill A. Shutemov
2008-10-03 12:44 ` Arjan van de Ven
2008-10-03 12:44 ` Arjan van de Ven
2008-10-03 12:58 ` Kirill A. Shutemov
2008-10-06 6:13 ` Andi Kleen
2008-10-06 6:13 ` Andi Kleen
2008-10-06 8:17 ` Kirill A. Shutemov
2008-10-06 8:42 ` Andi Kleen
2008-10-06 8:42 ` Andi Kleen
2008-10-06 9:17 ` Kirill A. Shutemov
2008-10-06 9:56 ` Andi Kleen
2008-10-06 9:56 ` Andi Kleen
2008-10-06 10:12 ` Kirill A. Shutemov
2008-10-06 13:26 ` Andi Kleen
2008-10-06 13:26 ` Andi Kleen
2008-10-06 14:37 ` [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT Kirill A. Shutemov
2008-10-06 14:37 ` Kirill A. Shutemov
2008-10-06 19:29 ` Andi Kleen
2008-10-06 19:29 ` Andi Kleen
2008-10-07 6:57 ` Kirill A. Shutemov
2008-10-07 6:57 ` [PATCH, RFC, v2] " Kirill A. Shutemov
2008-10-07 6:57 ` Kirill A. Shutemov
2008-10-07 8:20 ` Andi Kleen
2008-10-07 8:20 ` Andi Kleen
2008-10-07 10:09 ` Kirill A. Shutemov
2008-10-07 11:26 ` Andi Kleen
2008-10-07 11:26 ` Andi Kleen
2008-10-07 11:23 ` Kirill A. Shutemov
2008-10-07 14:38 ` Hugh Dickins
2008-10-07 14:38 ` Hugh Dickins
2008-10-07 15:10 ` Andi Kleen
2008-10-07 15:10 ` Andi Kleen
2008-10-07 11:08 ` [PATCH, RFC] " KOSAKI Motohiro
2008-10-07 11:08 ` KOSAKI Motohiro
2008-10-07 11:21 ` Andi Kleen
2008-10-07 11:21 ` Andi Kleen
2008-10-07 11:21 ` Kirill A. Shutemov
2008-10-07 11:26 ` KOSAKI Motohiro
2008-10-07 11:26 ` KOSAKI Motohiro
2008-10-07 11:30 ` Kirill A. Shutemov
2008-10-07 11:50 ` Andi Kleen
2008-10-07 11:50 ` Andi Kleen
2008-10-07 11:24 ` Kirill A. Shutemov
2008-10-07 12:31 ` Alan Cox
2008-10-07 12:31 ` Alan Cox
2008-10-07 13:14 ` Andi Kleen
2008-10-07 13:14 ` Andi Kleen
2008-10-03 9:33 ` [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT Kirill A. Shutemov
2008-10-03 9:33 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003080244.GC25408@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.