All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hans Werner" <HWerner4@gmx.de>
To: gimli@dark-green.com
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] [PATCH] Mantis Bug (was Technisat HD2 cannot szap/scan)
Date: Mon, 05 Jan 2009 18:36:06 +0100	[thread overview]
Message-ID: <20090105173606.271160@gmx.net> (raw)
In-Reply-To: <59327.62.178.208.71.1231173948.squirrel@webmail.dark-green.com>

> Hi,
> 
> with your patch i run into following problem on a Terratec Cinergy S2 PCI
> HD :
> 
> [  143.818103] stb6100_set_frequency: Frequency=1588000
> [  143.826681] stb6100_get_frequency: Frequency=1587990
> [  143.840867] stb6100_get_bandwidth: Bandwidth=10000000
> [  150.568018] mantis_ack_wait (0): Slave RACK Fail !
> [  150.568372] stb6100_set_bandwidth: Invalid parameter
> [  156.596525] mantis_ack_wait (0): Slave RACK Fail !
> [  156.596880] stb6100_get_bandwidth: Invalid parameter
> [  162.784014] mantis_ack_wait (0): Slave RACK Fail !
> [  162.784368] stb6100_get_bandwidth: Invalid parameter
> [  168.848014] mantis_ack_wait (0): Slave RACK Fail !
> [  168.848368] stb6100_set_frequency: Invalid parameter
> [  174.896016] mantis_ack_wait (0): Slave RACK Fail !
> [  174.896371] stb6100_get_frequency: Invalid parameter
> 
> cu
> 
> Edgar (gimli) Hucek

Hi Edgar,

I don't believe the Slave RACK problem is caused by my LNBP21 patch -- I saw it before
and I posted a fix for it already at
http://linuxtv.org/pipermail/linux-dvb/2008-December/030829.html

Here it is again:

diff -r 28324bc3d694 linux/drivers/media/dvb/mantis/mantis_i2c.c
--- a/linux/drivers/media/dvb/mantis/mantis_i2c.c
+++ b/linux/drivers/media/dvb/mantis/mantis_i2c.c
@@ -42,7 +42,7 @@ static int mantis_ack_wait(struct mantis
                dprintk(verbose, MANTIS_DEBUG, 1, "Master !I2CDONE");
                rc = -EREMOTEIO;
        }
-       while (!(mantis->mantis_int_stat & MANTIS_INT_I2CRACK)) {
+       while (!(mantis->mantis_int_stat & MANTIS_INT_I2CDONE)) {
                dprintk(verbose, MANTIS_DEBUG, 1, "Waiting for Slave RACK");
                mantis->mantis_int_stat = mmread(MANTIS_INT_STAT);
                msleep(5);


Regards,
Hans


> >> With the Azurewave AD-SP400 (Twinhan VP-1041 / Technisat HD2 /
> >> ?poss. Terratec Cinergy S2 PCI HD)
> >> there seems to be a driver bug when tuning some channels immediately
> >> after boot or after resuming from sleep (which is entered after 1
> minute
> >> idle).
> >> So the initialisation seems to be unsuitable for tuning some channels.
> >>
> >> But... if another channel is tuned successfully first then the bad
> >> channels *CAN* be tuned
> >> (if you are quick and do it before it sleeps again).
> >>
> >> It looks like the problem channels are all horizontal but perhaps other
> >> parameters are
> >> relevant too/instead.
> >>
> >> Can anyone help?
> >> Instructions for reproducing the problem on Astra 19.2E or Hotbird
> 13.0E
> >> are below.
> >>
> >> I don't know whether the problem is in the mantis, stb0899, stb6100 or
> >> lnbp21 code.
> >
> > Problem solved with the patch below.
> >
> > I found that both problems tuning channels (#1 immediately after boot
> and
> > #2 after sleep) are
> > caused by the lnbp21 voltage OFF setting. To fix #1: the LNB voltage
> needs
> > to be turned on when
> > the lnbp21 is attached, and to fix #2: turning the voltage off on sleep
> > needs to be disabled.
> >
> > To keep the voltage on, we need to make sure that register bit LNBP21_EN
> > is always set.
> >
> > I note that as well as controlling the voltage regulator blocks this
> > register bit also controls
> > a loopthrough switch -- clearing the bit takes the lnbp21 out of the LNB
> > line, which could be
> > used to allow other circuitry to do LNB power and control. I don't have
> > any info on how the
> > card is actually wired. It seems best to keep the EN bit always set,
> > because I know clearing
> > it causes trouble.
> >
> > It turns out there is already a mechanism for specifying register bits
> to
> > be overridden in
> > the lnbp21 attach call (already used for another card) and we just need
> to
> > apply the following
> > one-line patch to the VP-1041 attach.
> >
> > This is against the repository at
> > http://mercurial.intuxication.org/hg/s2-liplianin.
> >
> > Signed-off-by: Hans Werner <hwerner4@gmx.de>
> >
> > diff -r 28324bc3d694 linux/drivers/media/dvb/mantis/mantis_dvb.c
> > --- a/linux/drivers/media/dvb/mantis/mantis_dvb.c
> > +++ b/linux/drivers/media/dvb/mantis/mantis_dvb.c
> > @@ -239,7 +239,7 @@ int __devinit mantis_frontend_init(struc
> >                         vp1041_config.demod_address);
> >
> >                         if (stb6100_attach(mantis->fe,
> > &vp1041_stb6100_config, &mantis->adapter)) {
> > -                               if (!lnbp21_attach(mantis->fe,
> > &mantis->adapter, 0, 0)) {
> > +                               if (!lnbp21_attach(mantis->fe,
> > &mantis->adapter, LNBP21_EN, 0)) {
> >                                         printk("%s: No LNBP21 found!\n",
> > __FUNCTION__);
> >                                         mantis->fe = NULL;
> >                                 }
> >
> >
> >
> > Regards,
> > Hans

-- 
Release early, release often.

Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

  reply	other threads:[~2009-01-05 17:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 22:37 [linux-dvb] Technisat HD2 cannot szap/scan Pavel Hofman
2008-12-02  6:13 ` Michel Verbraak
2008-12-02 22:31   ` Pavel Hofman
     [not found]     ` <c74595dc0812022332s2ef51d1cn907cbe5e4486f496@mail.gmail.com>
     [not found]       ` <c74595dc0812022347j37e83279mad4f00354ae0e611@mail.gmail.com>
2008-12-03 23:24         ` Pavel Hofman
2008-12-05  6:22           ` [linux-dvb] Technisat HD2 cannot szap/scan (possible diseqc problem) Michel Verbraak
2008-12-05  9:00             ` Alex Betis
2008-12-06 17:07               ` Hans Werner
2008-12-06 17:28                 ` Alex Betis
2008-12-06 17:37                   ` Hans Werner
2008-12-09 15:34                 ` [linux-dvb] [PATCH] Technisat HD2 cannot szap/scan Hans Werner
2008-12-15 14:30                   ` [linux-dvb] Mantis Bug (was Technisat HD2 cannot szap/scan) Hans Werner
2009-01-04 19:24                     ` [linux-dvb] [PATCH] " Hans Werner
     [not found]                       ` <c74595dc0901042308j24fcbdebq3d6c51d2c68c8a73@mail.gmail.com>
2009-01-05 15:10                         ` [linux-dvb] [PATCH] stb6100: stb6100_init fix Hans Werner
     [not found]                           ` <b8a3b1ca0901051233u635b6d14u33d9d3b2f3d1ef61@mail.gmail.com>
2009-01-05 20:37                             ` [linux-dvb] Fwd: " Tomáš Skočdopole
2009-01-06 17:21                               ` [linux-dvb] " Newsy Paper
2009-01-05 16:45                       ` [linux-dvb] [PATCH] Mantis Bug (was Technisat HD2 cannot szap/scan) gimli
2009-01-05 17:36                         ` Hans Werner [this message]
2009-01-05 18:04                           ` gimli
2009-01-05 18:09                           ` gimli
2009-02-05 12:34                             ` Hans Werner
2009-02-06  7:14                               ` Alexey Klimov
2009-02-06 11:47                                 ` Hans Werner
2008-12-07 15:06           ` [linux-dvb] Technisat HD2 cannot szap/scan Pavel Hofman
2008-12-07 18:08             ` BOUWSMA Barry
2008-12-08 18:43               ` Pavel Hofman
2008-12-09  6:38                 ` BOUWSMA Barry
2008-12-08  6:52             ` Michel Verbraak
2008-12-08 18:54               ` Pavel Hofman
     [not found]             ` <c74595dc0812070822p73746bdel9894de34c87a733f@mail.gmail.com>
2008-12-08 18:39               ` Pavel Hofman
2008-12-08 19:53                 ` Alex Betis
2008-12-08 20:10                 ` BOUWSMA Barry
2008-12-08 22:19                   ` Pavel Hofman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090105173606.271160@gmx.net \
    --to=hwerner4@gmx.de \
    --cc=gimli@dark-green.com \
    --cc=linux-dvb@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.