Re: [PATCH] Mantis Bug (was Technisat HD2 cannot szap/scan)

[Alexey Klimov <klimov.linux@gmail.com>]

Hello,
i'm sorry to bother you with this small thing.

On Thu, 2009-02-05 at 13:34 +0100, Hans Werner wrote:
> > Hi,
> > 
> > checked it again. Your lnbp21 patch definitely kills S2 tuning
> > on the Terratec Cinergy S2 PCI HD.
> > 
> > mfg
> > 
> > Edgar ( gimli ) Hucek
> 
> 
> I looked at it again and here is a new patch to set the LNBP21 
> options for the Twinhan VP-1041. This works better for me, including
> DVB-S2 channels. The EN enable bit is now not permanently set so
> sleep behavior is correct.
> 
> Please note that I have a DiSEqC 1.2 rotor between the VP-1041 card
> and the LNB. That is quite a normal configuration, but the driver was
> probably not properly tested with rotors (and switches?) before.
> 
> To rotate with scan-s2 use the patch I posted, which will be applied
> there soon:
> http://linuxtv.org/pipermail/linux-dvb/2009-January/031660.html
> 
> Regards,
> Hans
> 
> Patch is against latest http://mercurial.intuxication.org/hg/s2-liplianin  repo.
> 
> Signed-off-by: Hans Werner <hwerner4@gmx.de>
>  
> diff -r 084878324629 linux/drivers/media/dvb/mantis/mantis_dvb.c
> --- a/linux/drivers/media/dvb/mantis/mantis_dvb.c
> +++ b/linux/drivers/media/dvb/mantis/mantis_dvb.c
> @@ -239,7 +239,8 @@ int __devinit mantis_frontend_init(struc
>  			vp1041_config.demod_address);
>  
>  			if (stb6100_attach(mantis->fe, &vp1041_stb6100_config, &mantis->adapter)) {
> -				if (!lnbp21_attach(mantis->fe, &mantis->adapter, 0, 0)) {
> +				// static current limit, no extra 1V, high current limit, tone from DSQIN pin (stb0899)

May i ask you not to use C99-style "// ..." comments ?
Linux style for comments is the C89 "/* ... */" style.

Honestly, when you do "make checkpatch" it will notify you about bad
things (style of comments included).


> +				if (!lnbp21_attach(mantis->fe, &mantis->adapter, LNBP21_PCL , LNBP21_LLC | LNBP21_ISEL | LNBP21_TEN)) {
>  					printk("%s: No LNBP21 found!\n", __FUNCTION__);
>  					mantis->fe = NULL;
>  				}
> 
-- 
Best regards, Klimov Alexey