From: Grant Likely <grant.likely@secretlab.ca>
To: davem@davemloft.net, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, michal.simek@petalogix.com,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au
Subject: [V2 PATCH 02/10] i2c/of: Allow device node to be passed via i2c_board_info
Date: Thu, 18 Mar 2010 09:22:16 -0600 [thread overview]
Message-ID: <20100318152216.21082.63.stgit@angua> (raw)
In-Reply-To: <20100318144836.21082.93040.stgit@angua>
The struct device_node *of_node pointer is moving out of dev->archdata
and into the struct device proper. of_i2c.c needs to set the of_node
pointer before the device is registered. Since the i2c subsystem
doesn't allow 2 stage allocation and registration of i2c devices, the
of_node pointer needs to be passed via the i2c_board_info structure
so that it is set prior to registration.
This patch adds of_node to struct i2c_board_info (conditional on
CONFIG_OF), sets of_node in i2c_new_device(), and modifies of_i2c.c
to use the new parameter. The calling of dev_archdata_set_node()
from of_i2c will be removed in a subsequent patch when of_node is
removed from archdata and all users are converted over.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/i2c/i2c-core.c | 3 +++
drivers/of/of_i2c.c | 1 +
include/linux/i2c.h | 4 ++++
3 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 3202a86..4099b2b 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -387,6 +387,9 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
client->dev.parent = &client->adapter->dev;
client->dev.bus = &i2c_bus_type;
client->dev.type = &i2c_client_type;
+#ifdef CONFIG_OF
+ client->dev.of_node = info->of_node;
+#endif
dev_set_name(&client->dev, "%d-%04x", i2c_adapter_id(adap),
client->addr);
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index a3a708e..e690a2a 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -43,6 +43,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
info.addr = be32_to_cpup(addr);
dev_archdata_set_node(&dev_ad, node);
+ info.of_node = node;
info.archdata = &dev_ad;
request_module("%s", info.type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 0a5da63..4f37ff1 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -34,6 +34,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/of.h> /* for struct device_node */
extern struct bus_type i2c_bus_type;
@@ -251,6 +252,9 @@ struct i2c_board_info {
unsigned short addr;
void *platform_data;
struct dev_archdata *archdata;
+#ifdef CONFIG_OF
+ struct device_node *of_node;
+#endif
int irq;
};
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: davem@davemloft.net, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, michal.simek@petalogix.com,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au
Subject: [V2 PATCH 02/10] i2c/of: Allow device node to be passed via
Date: Thu, 18 Mar 2010 15:22:16 +0000 [thread overview]
Message-ID: <20100318152216.21082.63.stgit@angua> (raw)
In-Reply-To: <20100318144836.21082.93040.stgit@angua>
The struct device_node *of_node pointer is moving out of dev->archdata
and into the struct device proper. of_i2c.c needs to set the of_node
pointer before the device is registered. Since the i2c subsystem
doesn't allow 2 stage allocation and registration of i2c devices, the
of_node pointer needs to be passed via the i2c_board_info structure
so that it is set prior to registration.
This patch adds of_node to struct i2c_board_info (conditional on
CONFIG_OF), sets of_node in i2c_new_device(), and modifies of_i2c.c
to use the new parameter. The calling of dev_archdata_set_node()
from of_i2c will be removed in a subsequent patch when of_node is
removed from archdata and all users are converted over.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/i2c/i2c-core.c | 3 +++
drivers/of/of_i2c.c | 1 +
include/linux/i2c.h | 4 ++++
3 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 3202a86..4099b2b 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -387,6 +387,9 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
client->dev.parent = &client->adapter->dev;
client->dev.bus = &i2c_bus_type;
client->dev.type = &i2c_client_type;
+#ifdef CONFIG_OF
+ client->dev.of_node = info->of_node;
+#endif
dev_set_name(&client->dev, "%d-%04x", i2c_adapter_id(adap),
client->addr);
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index a3a708e..e690a2a 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -43,6 +43,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
info.addr = be32_to_cpup(addr);
dev_archdata_set_node(&dev_ad, node);
+ info.of_node = node;
info.archdata = &dev_ad;
request_module("%s", info.type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 0a5da63..4f37ff1 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -34,6 +34,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/of.h> /* for struct device_node */
extern struct bus_type i2c_bus_type;
@@ -251,6 +252,9 @@ struct i2c_board_info {
unsigned short addr;
void *platform_data;
struct dev_archdata *archdata;
+#ifdef CONFIG_OF
+ struct device_node *of_node;
+#endif
int irq;
};
next prev parent reply other threads:[~2010-03-18 15:22 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 15:22 [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Grant Likely
2010-03-18 15:22 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in Grant Likely
2010-03-18 15:22 ` [V2 PATCH 01/10] driver-core: Add device node pointer to struct device Grant Likely
2010-03-18 15:22 ` Grant Likely
2010-03-18 15:22 ` Grant Likely [this message]
2010-03-18 15:22 ` [V2 PATCH 02/10] i2c/of: Allow device node to be passed via Grant Likely
2010-04-27 18:19 ` [V2 PATCH 02/10] i2c/of: Allow device node to be passed via i2c_board_info Grant Likely
[not found] ` <s2sfa686aa41004271119m4ff1390eh405726d78de86d09-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-28 11:44 ` Jean Delvare
2010-03-18 15:22 ` [V2 PATCH 03/10] arch/sparc: Always use 'struct device.of_node' to get device node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 03/10] arch/sparc: Always use 'struct device.of_node' to Grant Likely
2010-03-18 15:22 ` [V2 PATCH 04/10] arch/powerpc: Always use 'struct device.of_node' to get device node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 04/10] arch/powerpc: Always use 'struct device.of_node' to Grant Likely
2010-03-18 15:22 ` [V2 PATCH 05/10] arch/microblaze: Always use 'struct device.of_node' to get device node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 05/10] arch/microblaze: Always use 'struct device.of_node' Grant Likely
2010-03-18 15:22 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get Grant Likely
2010-03-18 15:58 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Jochen Friedrich
2010-03-18 15:58 ` Jochen Friedrich
2010-03-18 15:58 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Jochen Friedrich
2010-03-18 16:24 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Grant Likely
2010-03-18 16:24 ` Grant Likely
2010-03-18 16:24 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to Grant Likely
2010-03-18 16:59 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Sean MacLennan
2010-03-18 16:59 ` Sean MacLennan
2010-03-18 16:59 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Sean MacLennan
2010-03-18 17:07 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Grant Likely
2010-03-18 17:07 ` Grant Likely
2010-03-18 17:07 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to Grant Likely
2010-03-18 17:10 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Sean MacLennan
2010-03-18 17:10 ` Sean MacLennan
2010-03-18 17:10 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Sean MacLennan
2010-03-18 17:12 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Sean MacLennan
2010-03-18 17:12 ` Sean MacLennan
2010-03-18 17:12 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Sean MacLennan
2010-03-18 15:22 ` [V2 PATCH 07/10] of: eliminate calls to dev_archdata_set_node() Grant Likely
2010-03-18 15:22 ` Grant Likely
2010-03-18 15:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node Grant Likely
2010-03-18 15:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node Grant Likely
2010-03-18 15:47 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node Anton Vorontsov
2010-03-18 15:47 ` Anton Vorontsov
2010-03-18 15:47 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete Anton Vorontsov
2010-03-18 16:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node Grant Likely
2010-03-18 16:22 ` Grant Likely
2010-03-18 16:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete Grant Likely
2010-03-18 15:22 ` [V2 PATCH 09/10] arch/microblaze: Remove obsolete dev_archdata.of_node and of_devce.node Grant Likely
2010-03-18 15:22 ` [V2 PATCH 09/10] arch/microblaze: Remove obsolete Grant Likely
2010-03-18 15:23 ` [V2 PATCH 10/10] arch/sparc: Remove obsolete dev_archdata.prom_node and of_devce.node Grant Likely
2010-03-18 15:23 ` [V2 PATCH 10/10] arch/sparc: Remove obsolete dev_archdata.prom_node Grant Likely
2010-03-18 15:35 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Grant Likely
2010-03-18 15:35 ` Grant Likely
2010-03-18 15:35 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers Grant Likely
2010-03-23 6:57 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Michael Ellerman
2010-03-23 6:57 ` Michael Ellerman
2010-03-23 6:57 ` [V2 PATCH 00/10] of: Consolidate scattered device node Michael Ellerman
2010-03-23 7:06 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Grant Likely
2010-03-23 7:06 ` Grant Likely
2010-03-23 7:06 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318152216.21082.63.stgit@angua \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@petalogix.com \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.