From: Grant Likely <grant.likely@secretlab.ca>
To: davem@davemloft.net, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, michal.simek@petalogix.com,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au
Subject: [V2 PATCH 10/10] arch/sparc: Remove obsolete dev_archdata.prom_node and of_devce.node
Date: Thu, 18 Mar 2010 09:23:01 -0600 [thread overview]
Message-ID: <20100318152301.21082.93473.stgit@angua> (raw)
In-Reply-To: <20100318144836.21082.93040.stgit@angua>
Both dev_archdata.prom_node and of_device.node are duplications of the
device.of_node value. This patch removes them.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/sparc/include/asm/device.h | 15 ---------------
arch/sparc/include/asm/of_device.h | 1 -
arch/sparc/kernel/of_device_32.c | 2 --
arch/sparc/kernel/of_device_64.c | 2 --
arch/sparc/kernel/pci.c | 3 +--
5 files changed, 1 insertions(+), 22 deletions(-)
diff --git a/arch/sparc/include/asm/device.h b/arch/sparc/include/asm/device.h
index f3b85b6..d4c4521 100644
--- a/arch/sparc/include/asm/device.h
+++ b/arch/sparc/include/asm/device.h
@@ -13,25 +13,10 @@ struct dev_archdata {
void *iommu;
void *stc;
void *host_controller;
-
- struct device_node *prom_node;
struct of_device *op;
-
int numa_node;
};
-static inline void dev_archdata_set_node(struct dev_archdata *ad,
- struct device_node *np)
-{
- ad->prom_node = np;
-}
-
-static inline struct device_node *
-dev_archdata_get_node(const struct dev_archdata *ad)
-{
- return ad->prom_node;
-}
-
struct pdev_archdata {
};
diff --git a/arch/sparc/include/asm/of_device.h b/arch/sparc/include/asm/of_device.h
index a5d9811..f320246 100644
--- a/arch/sparc/include/asm/of_device.h
+++ b/arch/sparc/include/asm/of_device.h
@@ -14,7 +14,6 @@
*/
struct of_device
{
- struct device_node *node;
struct device dev;
struct resource resource[PROMREG_MAX];
unsigned int irqs[PROMINTR_MAX];
diff --git a/arch/sparc/kernel/of_device_32.c b/arch/sparc/kernel/of_device_32.c
index 7073117..47e63f1 100644
--- a/arch/sparc/kernel/of_device_32.c
+++ b/arch/sparc/kernel/of_device_32.c
@@ -345,11 +345,9 @@ static struct of_device * __init scan_one_device(struct device_node *dp,
return NULL;
sd = &op->dev.archdata;
- sd->prom_node = dp;
sd->op = op;
op->dev.of_node = dp;
- op->node = dp;
op->clock_freq = of_getintprop_default(dp, "clock-frequency",
(25*1000*1000));
diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device_64.c
index c8e352e..1dae807 100644
--- a/arch/sparc/kernel/of_device_64.c
+++ b/arch/sparc/kernel/of_device_64.c
@@ -640,11 +640,9 @@ static struct of_device * __init scan_one_device(struct device_node *dp,
return NULL;
sd = &op->dev.archdata;
- sd->prom_node = dp;
sd->op = op;
op->dev.of_node = dp;
- op->node = dp;
op->clock_freq = of_getintprop_default(dp, "clock-frequency",
(25*1000*1000));
diff --git a/arch/sparc/kernel/pci.c b/arch/sparc/kernel/pci.c
index c7a214e..8a8363a 100644
--- a/arch/sparc/kernel/pci.c
+++ b/arch/sparc/kernel/pci.c
@@ -261,8 +261,6 @@ static struct pci_dev *of_create_pci_dev(struct pci_pbm_info *pbm,
sd->iommu = pbm->iommu;
sd->stc = &pbm->stc;
sd->host_controller = pbm;
- sd->prom_node = node;
- dev->dev.of_node = node;
sd->op = op = of_find_device_by_node(node);
sd->numa_node = pbm->numa_node;
@@ -286,6 +284,7 @@ static struct pci_dev *of_create_pci_dev(struct pci_pbm_info *pbm,
dev->sysdata = node;
dev->dev.parent = bus->bridge;
dev->dev.bus = &pci_bus_type;
+ dev->dev.of_node = node;
dev->devfn = devfn;
dev->multifunction = 0; /* maybe a lie? */
set_pcie_port_type(dev);
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: davem@davemloft.net, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, michal.simek@petalogix.com,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au
Subject: [V2 PATCH 10/10] arch/sparc: Remove obsolete dev_archdata.prom_node
Date: Thu, 18 Mar 2010 15:23:01 +0000 [thread overview]
Message-ID: <20100318152301.21082.93473.stgit@angua> (raw)
In-Reply-To: <20100318144836.21082.93040.stgit@angua>
Both dev_archdata.prom_node and of_device.node are duplications of the
device.of_node value. This patch removes them.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/sparc/include/asm/device.h | 15 ---------------
arch/sparc/include/asm/of_device.h | 1 -
arch/sparc/kernel/of_device_32.c | 2 --
arch/sparc/kernel/of_device_64.c | 2 --
arch/sparc/kernel/pci.c | 3 +--
5 files changed, 1 insertions(+), 22 deletions(-)
diff --git a/arch/sparc/include/asm/device.h b/arch/sparc/include/asm/device.h
index f3b85b6..d4c4521 100644
--- a/arch/sparc/include/asm/device.h
+++ b/arch/sparc/include/asm/device.h
@@ -13,25 +13,10 @@ struct dev_archdata {
void *iommu;
void *stc;
void *host_controller;
-
- struct device_node *prom_node;
struct of_device *op;
-
int numa_node;
};
-static inline void dev_archdata_set_node(struct dev_archdata *ad,
- struct device_node *np)
-{
- ad->prom_node = np;
-}
-
-static inline struct device_node *
-dev_archdata_get_node(const struct dev_archdata *ad)
-{
- return ad->prom_node;
-}
-
struct pdev_archdata {
};
diff --git a/arch/sparc/include/asm/of_device.h b/arch/sparc/include/asm/of_device.h
index a5d9811..f320246 100644
--- a/arch/sparc/include/asm/of_device.h
+++ b/arch/sparc/include/asm/of_device.h
@@ -14,7 +14,6 @@
*/
struct of_device
{
- struct device_node *node;
struct device dev;
struct resource resource[PROMREG_MAX];
unsigned int irqs[PROMINTR_MAX];
diff --git a/arch/sparc/kernel/of_device_32.c b/arch/sparc/kernel/of_device_32.c
index 7073117..47e63f1 100644
--- a/arch/sparc/kernel/of_device_32.c
+++ b/arch/sparc/kernel/of_device_32.c
@@ -345,11 +345,9 @@ static struct of_device * __init scan_one_device(struct device_node *dp,
return NULL;
sd = &op->dev.archdata;
- sd->prom_node = dp;
sd->op = op;
op->dev.of_node = dp;
- op->node = dp;
op->clock_freq = of_getintprop_default(dp, "clock-frequency",
(25*1000*1000));
diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device_64.c
index c8e352e..1dae807 100644
--- a/arch/sparc/kernel/of_device_64.c
+++ b/arch/sparc/kernel/of_device_64.c
@@ -640,11 +640,9 @@ static struct of_device * __init scan_one_device(struct device_node *dp,
return NULL;
sd = &op->dev.archdata;
- sd->prom_node = dp;
sd->op = op;
op->dev.of_node = dp;
- op->node = dp;
op->clock_freq = of_getintprop_default(dp, "clock-frequency",
(25*1000*1000));
diff --git a/arch/sparc/kernel/pci.c b/arch/sparc/kernel/pci.c
index c7a214e..8a8363a 100644
--- a/arch/sparc/kernel/pci.c
+++ b/arch/sparc/kernel/pci.c
@@ -261,8 +261,6 @@ static struct pci_dev *of_create_pci_dev(struct pci_pbm_info *pbm,
sd->iommu = pbm->iommu;
sd->stc = &pbm->stc;
sd->host_controller = pbm;
- sd->prom_node = node;
- dev->dev.of_node = node;
sd->op = op = of_find_device_by_node(node);
sd->numa_node = pbm->numa_node;
@@ -286,6 +284,7 @@ static struct pci_dev *of_create_pci_dev(struct pci_pbm_info *pbm,
dev->sysdata = node;
dev->dev.parent = bus->bridge;
dev->dev.bus = &pci_bus_type;
+ dev->dev.of_node = node;
dev->devfn = devfn;
dev->multifunction = 0; /* maybe a lie? */
set_pcie_port_type(dev);
next prev parent reply other threads:[~2010-03-18 15:23 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 15:22 [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Grant Likely
2010-03-18 15:22 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in Grant Likely
2010-03-18 15:22 ` [V2 PATCH 01/10] driver-core: Add device node pointer to struct device Grant Likely
2010-03-18 15:22 ` Grant Likely
2010-03-18 15:22 ` [V2 PATCH 02/10] i2c/of: Allow device node to be passed via i2c_board_info Grant Likely
2010-03-18 15:22 ` [V2 PATCH 02/10] i2c/of: Allow device node to be passed via Grant Likely
2010-04-27 18:19 ` [V2 PATCH 02/10] i2c/of: Allow device node to be passed via i2c_board_info Grant Likely
[not found] ` <s2sfa686aa41004271119m4ff1390eh405726d78de86d09-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-28 11:44 ` Jean Delvare
2010-03-18 15:22 ` [V2 PATCH 03/10] arch/sparc: Always use 'struct device.of_node' to get device node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 03/10] arch/sparc: Always use 'struct device.of_node' to Grant Likely
2010-03-18 15:22 ` [V2 PATCH 04/10] arch/powerpc: Always use 'struct device.of_node' to get device node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 04/10] arch/powerpc: Always use 'struct device.of_node' to Grant Likely
2010-03-18 15:22 ` [V2 PATCH 05/10] arch/microblaze: Always use 'struct device.of_node' to get device node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 05/10] arch/microblaze: Always use 'struct device.of_node' Grant Likely
2010-03-18 15:22 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Grant Likely
2010-03-18 15:22 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get Grant Likely
2010-03-18 15:58 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Jochen Friedrich
2010-03-18 15:58 ` Jochen Friedrich
2010-03-18 15:58 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Jochen Friedrich
2010-03-18 16:24 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Grant Likely
2010-03-18 16:24 ` Grant Likely
2010-03-18 16:24 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to Grant Likely
2010-03-18 16:59 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Sean MacLennan
2010-03-18 16:59 ` Sean MacLennan
2010-03-18 16:59 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Sean MacLennan
2010-03-18 17:07 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Grant Likely
2010-03-18 17:07 ` Grant Likely
2010-03-18 17:07 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to Grant Likely
2010-03-18 17:10 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Sean MacLennan
2010-03-18 17:10 ` Sean MacLennan
2010-03-18 17:10 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Sean MacLennan
2010-03-18 17:12 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node to get node pointer Sean MacLennan
2010-03-18 17:12 ` Sean MacLennan
2010-03-18 17:12 ` [V2 PATCH 06/10] of/drivers: Always use struct device.of_node Sean MacLennan
2010-03-18 15:22 ` [V2 PATCH 07/10] of: eliminate calls to dev_archdata_set_node() Grant Likely
2010-03-18 15:22 ` Grant Likely
2010-03-18 15:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node Grant Likely
2010-03-18 15:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node Grant Likely
2010-03-18 15:47 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node Anton Vorontsov
2010-03-18 15:47 ` Anton Vorontsov
2010-03-18 15:47 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete Anton Vorontsov
2010-03-18 16:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node Grant Likely
2010-03-18 16:22 ` Grant Likely
2010-03-18 16:22 ` [V2 PATCH 08/10] arch/powerpc: Remove obsolete Grant Likely
2010-03-18 15:22 ` [V2 PATCH 09/10] arch/microblaze: Remove obsolete dev_archdata.of_node and of_devce.node Grant Likely
2010-03-18 15:22 ` [V2 PATCH 09/10] arch/microblaze: Remove obsolete Grant Likely
2010-03-18 15:23 ` Grant Likely [this message]
2010-03-18 15:23 ` [V2 PATCH 10/10] arch/sparc: Remove obsolete dev_archdata.prom_node Grant Likely
2010-03-18 15:35 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Grant Likely
2010-03-18 15:35 ` Grant Likely
2010-03-18 15:35 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers Grant Likely
2010-03-23 6:57 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Michael Ellerman
2010-03-23 6:57 ` Michael Ellerman
2010-03-23 6:57 ` [V2 PATCH 00/10] of: Consolidate scattered device node Michael Ellerman
2010-03-23 7:06 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device Grant Likely
2010-03-23 7:06 ` Grant Likely
2010-03-23 7:06 ` [V2 PATCH 00/10] of: Consolidate scattered device node pointers Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318152301.21082.93473.stgit@angua \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@petalogix.com \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.