From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "rydberg@euromail.se" <rydberg@euromail.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather
Date: Fri, 17 Dec 2010 21:57:08 +0000 [thread overview]
Message-ID: <20101217215708.GA10995@srcf.ucam.org> (raw)
In-Reply-To: <20101216170018.GA8140@ericsson.com>
On Thu, Dec 16, 2010 at 09:00:18AM -0800, Guenter Roeck wrote:
> I am having trouble applying this patch to my -next tree. The driver there
> (and in the official -next tree) has subtle differences to your version.
> What tree is your patch based on ? Can you rebase it to the -next tree and resubmit ?
My mistake - I'd pulled the patches from LKML, but it looks like there
was a later version of one or two.
> Couple of comments below; not necessarily complete, since I can not apply the patch.
> I hope Henrik can comment on the merits of the patch itself, ie if it is known to work
> with all systems.
> > +struct pnp_dev *pdev;
> > +struct applesmc_pnp_device *pnp_device;
> > +
> Please make those variables static.
Oops! Yup.
> Just wondering ... applesmc_pnp_device doesn't seem to be necessary.
> Why not just use the global variable directly if you have it anyway ?
This ended up left over as part of an attempt to get rid of the
globals...
> > + pnp_set_drvdata(dev, applesmc_pnp_device);
> > +
>
> ... but then since you assign it to drvdata, can you get rid of the global variable
> and use pnp_get_drvdata() whereever it is needed instead ?
But then I ran into some awkward issue and decided to leave it. And then
failed to clean everything up. I'll repost without that.
--
Matthew Garrett | mjg59@srcf.ucam.org
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "rydberg@euromail.se" <rydberg@euromail.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices
Date: Fri, 17 Dec 2010 21:57:08 +0000 [thread overview]
Message-ID: <20101217215708.GA10995@srcf.ucam.org> (raw)
In-Reply-To: <20101216170018.GA8140@ericsson.com>
On Thu, Dec 16, 2010 at 09:00:18AM -0800, Guenter Roeck wrote:
> I am having trouble applying this patch to my -next tree. The driver there
> (and in the official -next tree) has subtle differences to your version.
> What tree is your patch based on ? Can you rebase it to the -next tree and resubmit ?
My mistake - I'd pulled the patches from LKML, but it looks like there
was a later version of one or two.
> Couple of comments below; not necessarily complete, since I can not apply the patch.
> I hope Henrik can comment on the merits of the patch itself, ie if it is known to work
> with all systems.
> > +struct pnp_dev *pdev;
> > +struct applesmc_pnp_device *pnp_device;
> > +
> Please make those variables static.
Oops! Yup.
> Just wondering ... applesmc_pnp_device doesn't seem to be necessary.
> Why not just use the global variable directly if you have it anyway ?
This ended up left over as part of an attempt to get rid of the
globals...
> > + pnp_set_drvdata(dev, applesmc_pnp_device);
> > +
>
> ... but then since you assign it to drvdata, can you get rid of the global variable
> and use pnp_get_drvdata() whereever it is needed instead ?
But then I ran into some awkward issue and decided to leave it. And then
failed to clean everything up. I'll repost without that.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-17 21:57 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:33 [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding Matthew Garrett
2010-12-16 15:33 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 15:33 ` [lm-sensors] [PATCH 2/2] applesmc: Perform some more sanity Matthew Garrett
2010-12-16 15:33 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-16 16:48 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Henrik Rydberg
2010-12-16 16:48 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Matthew Garrett
2010-12-16 17:00 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Guenter Roeck
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-17 21:57 ` Matthew Garrett [this message]
2010-12-17 21:57 ` Matthew Garrett
2010-12-17 21:58 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding Matthew Garrett
2010-12-17 21:58 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:16 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Guenter Roeck
2010-12-17 22:16 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-17 22:22 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Matthew Garrett
2010-12-17 22:22 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:24 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-17 22:24 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 4:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Guenter Roeck
2010-12-18 4:23 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-18 9:07 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 9:07 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 14:40 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 14:40 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 15:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 15:31 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 9:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 9:37 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 10:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Jean Delvare
2010-12-18 10:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Jean Delvare
2010-12-18 10:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 10:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 11:29 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Julien BLACHE
2010-12-18 11:29 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Julien BLACHE
2010-12-18 11:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 11:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 13:44 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Mikael Ström
2010-12-20 13:44 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Mikael Ström
2010-12-20 13:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Jean Delvare
2010-12-20 13:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Jean Delvare
2010-12-20 14:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 14:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 14:28 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 14:28 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-20 15:06 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 15:06 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 15:12 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 15:12 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-20 15:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 15:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 14:00 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 14:00 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-21 6:04 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Mikael Ström
2010-12-21 6:04 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Mikael Ström
2010-12-21 11:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Julien BLACHE
2010-12-21 11:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Julien BLACHE
2010-12-18 14:43 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 14:43 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 15:30 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 15:30 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 15:39 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 15:39 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:24 ` [lm-sensors] [PATCH 2/2 V3] applesmc: Perform some more sanity Matthew Garrett
2010-12-17 22:24 ` [PATCH 2/2 V3] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-17 21:58 ` [lm-sensors] [PATCH 2/2] applesmc: Perform some more sanity Matthew Garrett
2010-12-17 21:58 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217215708.GA10995@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.