From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than
Date: Sat, 18 Dec 2010 14:40:49 +0000 [thread overview]
Message-ID: <20101218144049.GA21801@srcf.ucam.org> (raw)
In-Reply-To: <20101218090714.GA436@polaris.bitmath.org>
On Sat, Dec 18, 2010 at 10:07:14AM +0100, Henrik Rydberg wrote:
> On Fri, Dec 17, 2010 at 08:23:21PM -0800, Guenter Roeck wrote:
> > On Fri, Dec 17, 2010 at 05:24:20PM -0500, Matthew Garrett wrote:
> > > The AppleSMC device is described in ACPI, including a list of its resources.
> > > We should use those rather than hardcoding the ports. A side-effect is that
> > > we can then remove the DMI matching, since there's a unique identifier to
> > > indicate that the machine has one of these devices.
> > >
> > > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> >
> > You added a whitespace error, and kfree() is safe and doesn't need a check.
> > I fixed those, so no need to resubmit. If Henrik gives his Ack we are ready to go.
>
> Thanks, I will give it some testing before doing so. Matthew, did you
> test this under EFI boot? Also, NOTIFICATION_KEY does not seem to be
> used anywhere.
I tested under EFI and BIOS. NOTIFICATION_KEY is there for adding
interrupt support - I got that hooked up but it seems that the latest
Air is lacking the sudden motion sensor (probably because it's an
SSD-only model) so wasn't able to test it. I'll play some more and add a
further patch for that.
--
Matthew Garrett | mjg59@srcf.ucam.org
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices
Date: Sat, 18 Dec 2010 14:40:49 +0000 [thread overview]
Message-ID: <20101218144049.GA21801@srcf.ucam.org> (raw)
In-Reply-To: <20101218090714.GA436@polaris.bitmath.org>
On Sat, Dec 18, 2010 at 10:07:14AM +0100, Henrik Rydberg wrote:
> On Fri, Dec 17, 2010 at 08:23:21PM -0800, Guenter Roeck wrote:
> > On Fri, Dec 17, 2010 at 05:24:20PM -0500, Matthew Garrett wrote:
> > > The AppleSMC device is described in ACPI, including a list of its resources.
> > > We should use those rather than hardcoding the ports. A side-effect is that
> > > we can then remove the DMI matching, since there's a unique identifier to
> > > indicate that the machine has one of these devices.
> > >
> > > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> >
> > You added a whitespace error, and kfree() is safe and doesn't need a check.
> > I fixed those, so no need to resubmit. If Henrik gives his Ack we are ready to go.
>
> Thanks, I will give it some testing before doing so. Matthew, did you
> test this under EFI boot? Also, NOTIFICATION_KEY does not seem to be
> used anywhere.
I tested under EFI and BIOS. NOTIFICATION_KEY is there for adding
interrupt support - I got that hooked up but it seems that the latest
Air is lacking the sudden motion sensor (probably because it's an
SSD-only model) so wasn't able to test it. I'll play some more and add a
further patch for that.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-18 14:40 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:33 [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding Matthew Garrett
2010-12-16 15:33 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 15:33 ` [lm-sensors] [PATCH 2/2] applesmc: Perform some more sanity Matthew Garrett
2010-12-16 15:33 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-16 16:48 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Henrik Rydberg
2010-12-16 16:48 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Matthew Garrett
2010-12-16 17:00 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Guenter Roeck
2010-12-16 17:00 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-17 21:57 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather Matthew Garrett
2010-12-17 21:57 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 21:58 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than hardcoding Matthew Garrett
2010-12-17 21:58 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:16 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Guenter Roeck
2010-12-17 22:16 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-17 22:22 ` [lm-sensors] [PATCH 1/2] applesmc: Use PnP rather than Matthew Garrett
2010-12-17 22:22 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:24 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-17 22:24 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 4:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Guenter Roeck
2010-12-18 4:23 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Guenter Roeck
2010-12-18 9:07 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 9:07 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 14:40 ` Matthew Garrett [this message]
2010-12-18 14:40 ` Matthew Garrett
2010-12-18 15:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 15:31 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 9:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 9:37 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 10:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Jean Delvare
2010-12-18 10:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Jean Delvare
2010-12-18 10:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 10:31 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 11:29 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Julien BLACHE
2010-12-18 11:29 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Julien BLACHE
2010-12-18 11:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 11:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 13:44 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Mikael Ström
2010-12-20 13:44 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Mikael Ström
2010-12-20 13:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Jean Delvare
2010-12-20 13:57 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Jean Delvare
2010-12-20 14:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 14:23 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 14:28 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 14:28 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-20 15:06 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 15:06 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 15:12 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 15:12 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-20 15:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-20 15:37 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-20 14:00 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather Matthew Garrett
2010-12-20 14:00 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-21 6:04 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Mikael Ström
2010-12-21 6:04 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Mikael Ström
2010-12-21 11:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Julien BLACHE
2010-12-21 11:09 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Julien BLACHE
2010-12-18 14:43 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 14:43 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-18 15:30 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Henrik Rydberg
2010-12-18 15:30 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-18 15:39 ` [lm-sensors] [PATCH 1/2 V3] applesmc: Use PnP rather than Matthew Garrett
2010-12-18 15:39 ` [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-17 22:24 ` [lm-sensors] [PATCH 2/2 V3] applesmc: Perform some more sanity Matthew Garrett
2010-12-17 22:24 ` [PATCH 2/2 V3] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-17 21:58 ` [lm-sensors] [PATCH 2/2] applesmc: Perform some more sanity Matthew Garrett
2010-12-17 21:58 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218144049.GA21801@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.